Fix xdp-forward loading and unloading in some cases #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BPF function names used by xdp-forward in flowtable mode end up being ambiguous when truncated by the kernel. This causes xdp-forward to be unable to unload the programs. Fix this by using shorter function names. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
The DEVMAP map types used by xdp-forward prevents installing xdp-forward on ifindexes larger than the map size, because the ifindex is also used as the lookup key. Change to DEVMAP_HASH to avoid this. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Converting errno returns to program exit status means we may end up returning SKIPPED_TEST, which messes with the selftests. Change this to always use EXIT_SUCCESS/EXIT_FAILURE instead. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
The flowtable test for xdp-forward did not unload the programs after running, which is why it didn't catch the ambiguous program name error. Add an unload to the text to make sure this keeps working. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Add a test that creates an interface with a high ifindex and verify that xdp-forward can attach to it. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
tohojo
force-pushed
the
xdp-forward-fixes
branch
from
8714c94 to
1bf5e3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sbraz discovered that xdp-forward can't unload properly when run in flowtable
mode. It turns out we also can't attach to interfaces with high ifindexes. Fix
both issues and add tests to verify.
Fixes #487.