Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drive the MLIR lowering through xDSL. #56

Merged
merged 12 commits into from
Feb 21, 2024
Merged

Drive the MLIR lowering through xDSL. #56

merged 12 commits into from
Feb 21, 2024

Conversation

PapyChacal
Copy link
Collaborator

@PapyChacal PapyChacal commented Feb 14, 2024 •
edited
Loading

Drive MLIR pipeline through xDSL to prepare for more back and forth.
Tested working and correct for GPU locally.

@PapyChacal PapyChacal self-assigned this Feb 14, 2024
@PapyChacal PapyChacal mentioned this pull request Feb 15, 2024
Closed
@PapyChacal PapyChacal changed the title Emilien/mlir xdsl Drive the MLIR lowering through xDSL. Feb 20, 2024
@PapyChacal PapyChacal marked this pull request as ready for review February 20, 2024 12:29
georgebisbas
georgebisbas reviewed Feb 20, 2024
View reviewed changes
georgebisbas
georgebisbas reviewed Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks better! Could you maybe enhance with some doc/comments, for future reference? and maybe drop commented out lines?
I would just like this to be cleaner for someone that "is not us"

georgebisbas
georgebisbas reviewed Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 needs some fixing

@georgebisbas georgebisbas self-requested a review February 21, 2024 13:28
georgebisbas
georgebisbas requested changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8

@PapyChacal
Copy link
Collaborator Author

PapyChacal commented Feb 21, 2024 •
edited
Loading

flake8

✅

@PapyChacal PapyChacal merged commit 3dd26da into master Feb 21, 2024
3 checks passed
@PapyChacal PapyChacal deleted the emilien/mlir-xdsl branch February 21, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgebisbas georgebisbas georgebisbas requested changes

Assignees

@PapyChacal PapyChacal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PapyChacal @georgebisbas