Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (builtin) make DenseIntOrFPElementsAttr a TypedAttribute #3509

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

alexarice
Copy link
Collaborator

@alexarice alexarice commented Nov 22, 2024

A simpler version of #3492 which does not make DenseIntOrFPElementsAttr generic.

Super stacked PR Unstacked

@alexarice alexarice added dialects Changes on the dialects core xDSL core (ir, textual format, ...) labels Nov 22, 2024
@alexarice alexarice self-assigned this Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (2a7fa60) to head (bc5ea1e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3509      +/-   ##
==========================================
- Coverage   90.34%   90.34%   -0.01%     
==========================================
  Files         464      464              
  Lines       58039    58048       +9     
  Branches     5549     5549              
==========================================
+ Hits        52436    52442       +6     
- Misses       4177     4179       +2     
- Partials     1426     1427       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Base automatically changed from alexarice/typed-attribute-helper to main November 22, 2024 17:30
@alexarice alexarice force-pushed the alexarice/dense-typed-simple branch from 50eca90 to a21644a Compare November 22, 2024 17:31
@alexarice alexarice merged commit 018d17f into main Nov 22, 2024
15 checks passed
@alexarice alexarice deleted the alexarice/dense-typed-simple branch November 22, 2024 23:53
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
…dslproject#3509)

A simpler version of xdslproject#3492 which does not make
`DenseIntOrFPElementsAttr` generic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...) dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants