fix: initial untrained skill value (#1564)

This small update fixes an issue where the initial value of the Untrained Skill is set to 0 and not -3 for a new Actor. The update also adds ES localization courtesy of @ForjaSalvaje
xdy · May 4, 2024 · 5f4a8a6 · 5f4a8a6
1 parent 19b365a
commit 5f4a8a6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/module/entities/TwodsixActor.ts b/src/module/entities/TwodsixActor.ts
@@ -676,7 +676,7 @@ export default class TwodsixActor extends Actor {
       "name": game.i18n.localize("TWODSIX.Actor.Skills.Untrained"),
       "type": "skills",
       "system": {"characteristic": "NONE"},
-      "flags": {'twodsix.untrainedSkill': true},
+      "flags": {'twodsix': {'untrainedSkill': true}},
       "img": "./systems/twodsix/assets/icons/jack-of-all-trades.svg"
     };
 

diff --git a/src/module/entities/TwodsixItem.ts b/src/module/entities/TwodsixItem.ts
@@ -46,7 +46,7 @@ export default class TwodsixItem extends Item {
       }
     }
 
-    if (this.type === "skills" && game.settings.get('twodsix', 'hideUntrainedSkills')) {
+    if (this.type === "skills" && game.settings.get('twodsix', 'hideUntrainedSkills') && !this.getFlag('twodsix', 'untrainedSkill')) {
       Object.assign(updates, {"system.value": 0});
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -46,7 +46,7 @@ export default class TwodsixItem extends Item { @@
           }
         }
-        if (this.type === "skills" && game.settings.get('twodsix', 'hideUntrainedSkills')) {
+        if (this.type === "skills" && game.settings.get('twodsix', 'hideUntrainedSkills') && !this.getFlag('twodsix', 'untrainedSkill')) {
           Object.assign(updates, {"system.value": 0});
         }
@@ Expand Down @@