Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTelemetry improved #756

Merged
merged 4 commits into from
Jun 7, 2024
Merged

OpenTelemetry improved #756

merged 4 commits into from
Jun 7, 2024

Conversation

javipacheco
Copy link
Contributor

This PR:

  • Adds the missing elements in the stream
  • Write the name of the data class in the span instead of the status
  • Calculate the time os the span in the Run, RunStep and MessageCreation

Screenshot 2024-06-06 at 16 41 27

Montagon
Montagon previously approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@Montagon Montagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, thanks Javi!

core/src/commonMain/kotlin/com/xebia/functional/xef/llm/MetricManagement.kt Outdated Show resolved Hide resolved
@raulraja raulraja merged commit 5621c97 into main Jun 7, 2024
6 checks passed
@raulraja raulraja deleted the open-telemetry-improved branch June 7, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

@Montagon Montagon Montagon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javipacheco @raulraja @Montagon