Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Assistant Tool input and output json config #790

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

realdavidvega
Copy link
Contributor

@realdavidvega realdavidvega commented Sep 26, 2024

Background

Previously, the configuration for serialization of both the input and output of tools was common. This means both were treated with the same settings, potentially leading to inefficiencies or non-optimal behavior.

This PR

This PR differentiates the serialization configuration for the tool's input and output JSON.

E.g. It would allow to set parameters like explicitNulls = true for inputs, ensuring that null values are explicitly included, while setting it to false for outputs, to potentially omit unnecessary nulls.

@realdavidvega realdavidvega self-assigned this Sep 26, 2024
@realdavidvega realdavidvega merged commit e5916d6 into main Sep 27, 2024
6 checks passed
@realdavidvega realdavidvega deleted the feature/separate-json-tool-config branch September 27, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants