Add cache policies to CachedTool #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The existing implementation of the
CachedToolabstract class supports caching and some criteria to determine the usage and writing on cache. However, there's no customization on the cache eviction and expiration. by default, there's only write timestamp, and cache eviction happens for the found key only.This PR
CachedToolValue, one for access and other for write.CacheExpirationPolicyto expire by write timestamp or access timestamp. By default it isWRITE.CacheEvictionPolicyto evict only the found key, or to evict all expired entries. By default it isALL.cachemethod in order to make work this new features.