V4H domain reboot #219
Merged
V4H domain reboot #219
+147
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrygiriiS
reviewed
Dec 11, 2024
|
|
||
| mfis_data->domains[chan] = d; | ||
|
|
||
| printk("MFIS: Added chan %d for domain %d\n", chan, d->domain_id); |
|
|
||
| return -ENOENT; | ||
| printk("MFIS: Removed chan %d for domain %d\n", chan, d->domain_id); |
|
It seems like a minor misprint in the second commit message: 'otherend.' |
added 2 commits
December 12, 2024 16:54
A prerequisite patch for implementing domain restart. Also fix misc issues which I have found during refactoring. Such as validating vgic_reserve_virq() to return a boolean with true being a success value, checking the page to be a non-zero value before releasing as a guest specifying PA above 4GB can crash Xen, iterate, and checking the rproc channel against rproc_data->vq_cnt instead of mfis_data->chan_cnt, adding missing __init annotation, etc. The current diff looks non-ideal, but refer to the subsequent commit which diff looks much more cleaner. Signed-off-by: Oleksandr Tyshchenko <[email protected]>
Add specific events to notify otherend when rproc-enabled domain is created or destroyed. Waiting for the ack or otherwise when sending these events from mfis_add_domain()/mfis_remove_domain() (not a hot path). Signed-off-by: Oleksandr Tyshchenko <[email protected]>
otyshchenko1
force-pushed
the
v4h_domain_reboot
branch
from
405b506 to
41e7453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with xl destroy/create and xl reboot, w/ and w/o GPU rendering app/modetest running using custom reduced DomU (with rproc/rvgc and GPU only). No issues were observed. After DomU restart, everything remains working in the context of Shared display feature.