Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: serial: add support of hscif driver for RCar boards #115

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

lorc
Copy link
Collaborator

@lorc lorc commented Jun 14, 2024

Add support of HSCIF UART driver for Renesas boards.


This is backport from mainline Zephyr.

Copy link
Collaborator

@xakep-amatop xakep-amatop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorc
Copy link
Collaborator Author

lorc commented Jun 14, 2024

Interestingly, HSCIF nodes are already present:

https://github.com/xen-troops/zephyr/blob/zephyr-v3.6.0-xt/boards/arm64/rcar_spider_ca55/rcar_spider_ca55.dts#L32

All I had to do is port this one patch.

@xakep-amatop
Copy link
Collaborator

Interestingly, HSCIF nodes are already present:

https://github.com/xen-troops/zephyr/blob/zephyr-v3.6.0-xt/boards/arm64/rcar_spider_ca55/rcar_spider_ca55.dts#L32

All I had to do is port this one patch.

My apologies, I've checked the zephyr-v3.3.0-xt branch for these changes instead of zephyr-v3.6.0-xt.

@GrygiriiS
Copy link

GrygiriiS commented Jun 17, 2024

Please, add explicit note in commit message that it's back port:("cherry-pick -x") or smth. like "[commit <hash> upstream]".

@lorc
Copy link
Collaborator Author

lorc commented Jun 17, 2024

Updated the commit message

Copy link
Collaborator

@firscity firscity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked-by: Dmytro Firsov <[email protected]>

@GrygiriiS
Copy link

Updated the commit message

Thank you, nut note, commit SHA should be 12 digit/chars

@lorc
Copy link
Collaborator Author

lorc commented Jun 18, 2024

Thank you, nut note, commit SHA should be 12 digit/chars

Are you sure? As I can see, Linux kernel developers always us full SHA1 hash. Also, please note that GitHub mangles commit messages. In this case it replaced full SHA1 hash with shortened one and made it a hyperlink.

commit 448466a upstream

Add support of HSCIF UART driver for Renesas boards.

Signed-off-by: Mykola Kvach <[email protected]>
Acked-by: Dmytro Firsov <[email protected]>
@GrygiriiS
Copy link

Thank you, nut note, commit SHA should be 12 digit/chars

Are you sure? As I can see, Linux kernel developers always us full SHA1 hash. Also, please note that GitHub mangles commit messages. In this case it replaced full SHA1 hash with shortened one and made it a hyperlink.

12 is min. I've no objections to this PR, especially considering your comment about github behavior. I can't add my tag here as I'm not familiar with HW.

@lorc
Copy link
Collaborator Author

lorc commented Jun 18, 2024

I've no objections to this PR, especially considering your comment about github behavior

Yeah, you can check the raw commit by adding ".patch" to the patch URL

https://github.com/xen-troops/zephyr/commit/5119451f3437a4d606a402a707c72f9d5f016352.patch

@firscity firscity merged commit 432844b into xen-troops:zephyr-v3.6.0-xt Jun 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants