-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: serial: add support of hscif driver for RCar boards #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is also necessary to add a node of HSCIF, as has been done in the mainline:
https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/arm64/renesas/r8a779f0.dtsi#L110
https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/renesas/rcar_spider_s4/rcar_spider_s4_r8a779f0_a55-pinctrl.dtsi#L10
https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/renesas/rcar_spider_s4/rcar_spider_s4_r8a779f0_a55.dts#L27
Interestingly, HSCIF nodes are already present: All I had to do is port this one patch. |
My apologies, I've checked the |
Please, add explicit note in commit message that it's back port: |
Updated the commit message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acked-by: Dmytro Firsov <[email protected]>
Thank you, nut note, commit SHA should be 12 digit/chars |
Are you sure? As I can see, Linux kernel developers always us full SHA1 hash. Also, please note that GitHub mangles commit messages. In this case it replaced full SHA1 hash with shortened one and made it a hyperlink. |
commit 448466a upstream Add support of HSCIF UART driver for Renesas boards. Signed-off-by: Mykola Kvach <[email protected]> Acked-by: Dmytro Firsov <[email protected]>
12 is min. I've no objections to this PR, especially considering your comment about github behavior. I can't add my tag here as I'm not familiar with HW. |
Yeah, you can check the raw commit by adding ".patch" to the patch URL https://github.com/xen-troops/zephyr/commit/5119451f3437a4d606a402a707c72f9d5f016352.patch |
Add support of HSCIF UART driver for Renesas boards.
This is backport from mainline Zephyr.