Fixes for Xen grant table driver #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xakep-amatop
approved these changes
Nov 28, 2024
| @@ -382,13 +380,6 @@ static int gnttab_init(void) | |||
| __ASSERT(!rc, "add_to_physmap failed; status = %d\n", rc); | |||
There was a problem hiding this comment.
This question is not related to these changes, but AFAIU this assert will work only in test builds: https://elixir.bootlin.com/zephyr/v4.0.0/source/subsys/debug/Kconfig#L249.
Is this expected, or should we use something else for assertions in any case?
There was a problem hiding this comment.
IIUC the purpose of asserts is Zephyr - it is expected to appear as critical error on test builds and completely disappear on target builds. Since we depend on hypervisor here, just if() will be more correct, assert is legacy taken from mini-os driver.
|
Good job! |
Initially this driver was a port from mini-os. Michal Orzel (@orzelmichal) pointed that it contains incorrect grant table initialization sequence and redundant calls. Driver mapped grant table frames via loop of XENMEM_add_to_physmap calls and then tried to do the same but via GNTTABOP_setup_table operation. After completion of latter it did not even use provided frames list. This did not cause any major issues, since XENMEM_add_to_physmap correctly map gnttab frames that were used. Remove redundant GNTTABOP_setup_table call from grant table driver to clean up its initialization sequence. Signed-off-by: Dmytro Firsov <[email protected]> Acked-by: Leonid Komarianskyi <[email protected]>
Previously driver gnttab_unmap_refs() signature used incorrect struct - the same one, that is used for mapping. Since host_addr field, that is used to point to required frame is first in both structures it somehow worked. Fix mistake and use 'struct gnttab_unmap_grant_ref' for grant frames unmapping hypercalls. Signed-off-by: Dmytro Firsov <[email protected]> Acked-by: Leonid Komarianskyi <[email protected]>
firscity
force-pushed
the
gnttab_3.6.0_fixes
branch
from
934487c to
d74eb31
Compare
|
@LKomaryanskiy thanks for review, added AB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits in this PR fixes 2 issues in Xen grant table driver for Zephyr RTOS:
These changes will be also upstreamed to Zephyr RTOS main branch