drivers: serial: Disable interrupts in SCIF driver #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
please no fixup for already released code |
dsemenets
force-pushed
the
rza2m_uart_fix
branch
from
3f08337 to
dcda051
Compare
lorc
approved these changes
Mar 27, 2024
dsemenets
force-pushed
the
rza2m_uart_fix
branch
2 times, most recently
from
62da96c to
6dc661a
Compare
firscity
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
s/ans/and in drivers: serial: Disable interrupts in SCIF driver commit message
with this fix:
Acked-by: Dmytro Firsov <[email protected]>
SCIF uses interrups by LEVEL and TX interrupt is fired if FIFO is not full. In this case interrupt is faired immediately after exit from ISR. Disable interrupts in SCIF driver after DMA operation finished. We don't need enabled interrupts if nothing to transmit. Signed-off-by: Dmytro Semenets <[email protected]> Reviewed-by: Oleksii Moisieiev <[email protected]> Acked-by: Volodymyr Babchuk <[email protected]> Acked-by: Dmytro Firsov <[email protected]>
Fixed missprint in #ifdef condition. Signed-off-by: Dmytro Semenets <[email protected]> Reviewed-by: Oleksii Moisieiev <[email protected]> Acked-by: Volodymyr Babchuk <[email protected]> Acked-by: Dmytro Firsov <[email protected]>
dsemenets
force-pushed
the
rza2m_uart_fix
branch
from
6dc661a to
f2f90e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable interrupts in SCIF driver after DMA operation finished. If interrupts remains enabled it leads to hangs in ISR.