Zephyr v3.6.0 xt rpi5 dom0 wip #94

GrygiriiS · 2024-04-17T13:55:41Z

First iteration of enabling RPI 5 in Zephyr and adding Dom0 functionality

GrygiriiS · 2024-04-17T13:56:44Z

@oleksiimoisieiev @dsemenets @xakep-amatop @Deedone

oleksiimoisieiev · 2024-04-18T07:10:50Z

lgtm
Acked-by: Oleksii Moisieiev <[email protected]>

GrygiriiS · 2024-04-18T07:12:43Z

Some checks failed on RPI5 initial patches as those patches ported as is from Zephyr ML. Those patches will need to be updated later any way when (if) they'll be merged in Zephyr ML. I have no intention to fix those CI warnings now.

UPD: fixed

github-actions · 2024-04-19T09:45:39Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

firscity

Please, fix checkpatch warnings.

Also commits

dts: arm64: broadcom: bcm2712: add psci and compatible - add proper explanation for this
drivers: xen: add XEN_EVENTS Kconfig option
but thay might be not used. - > but they might be not used.
boards: arm64: xenvm: reduce hypervisor node memory - please, mark this as a "WA" in commit topic, I will provide a proper solution soon.

boards/arm64/xenvm/xenvm_defconfig

boards/arm64/rpi_5/Kconfig.board

submanifests/zephyr-xenlib.yaml

include/zephyr/xen/public/domctl.h

boards/arm64/rpi_5/Kconfig.defconfig

GrygiriiS · 2024-04-26T13:43:39Z

RPI5 commits went upstream, so cherry-picked and noted.
Other comments fixed.

drivers/xen/Kconfig

firscity · 2024-04-29T21:35:36Z

boards/arm64/xenvm/xenvm.dts

@@ -69,7 +69,7 @@

 	hypervisor: hypervisor@38000000 {
 		compatible = "xen,xen";
-		reg = <0x00 0x38000000 0x00 0x1000000>;
+		reg = <0x00 0x38000000 0x00 0x10000>;


Should be removed after #96 will be merged

boards/arm64/rpi_5/doc/index.rst

firscity · 2024-04-29T21:45:07Z

boards/arm64/rpi_5/doc/index.rst

+The Raspberry Pi 5 platform can be used to run as Xen Zephyr DomU with RPI 5 HW support.
+For such purposes the `rpi_5_xen_domd` can be used.
+
+Run below command as an example of RPI 5 Zephyr build as Dom0:


Run below command -> Run the command below

example of RPI 5 Zephyr build as Dom0 - probably copy-paste issue

boards/arm64/rpi_5/doc/index.rst

Deedone · 2024-04-30T10:28:54Z

drivers/gpio/gpio_brcmstb.c

+
+static int gpio_brcmstb_pin_configure(const struct device *port, gpio_pin_t pin, gpio_flags_t flags)
+{
+	struct gpio_brcmstb_data *data = port->data;


Null check?

First it's not my patch and it's explicitly marked as back-ported (with "cherry picked from commit 31badda", so probably right place for comments is in Zephyr mainline zephyrproject-rtos#70538.

Second, those functions are not called directly, but through the gpio APIs and null is impossible here.

Deedone · 2024-04-30T10:30:06Z

drivers/gpio/gpio_brcmstb.c

+
+static int gpio_brcmstb_port_get_raw(const struct device *port, gpio_port_value_t *value)
+{
+	struct gpio_brcmstb_data *data = port->data;


Same, please check all pointers for NULL value.

the same as above

Deedone · 2024-04-30T10:34:44Z

soc/arm64/bcm2712/CMakeLists.txt

+# SPDX-License-Identifier: Apache-2.0
+zephyr_sources_ifdef(CONFIG_ARM_MMU mmu_regions.c)
+
+set(SOC_LINKER_SCRIPT ${ZEPHYR_BASE}/include/zephyr/arch/arm64/scripts/linker.ld CACHE INTERNAL "")


Could you add some comments describing why is this needed pls?

same as above

Deedone · 2024-04-30T10:38:04Z

snippets/rpi_5_xen_domd/README.rst

@@ -0,0 +1,17 @@
+.. _rpi_5_xen_domd:
+
+RPI 5 Xen DomD: snippet for XEN HW domain


Do we really need separate snippets for DomD and DomUs? AFAIK there is no real difference between them, so what is the reason for explicitly specifying DomD here?

if you look at code ypu'll see DomD based on xenvm DT + passedthrough HW, Dom0 has different Xen specific DT and no HW for now. Those are NOT compatible.

Add GPIO driver for brcmstb, required by Raspberry Pi 5. Signed-off-by: Junho Lee <[email protected]> (cherry picked from commit 31badda) Signed-off-by: Grygorii Strashko <[email protected]>

Add support for BCM2712, SoC of Raspberry Pi 5. Signed-off-by: Junho Lee <[email protected]> (cherry picked from commit 76ec481) Signed-off-by: Grygorii Strashko <[email protected]>

Add support for Raspberry Pi 5. Currently only internal GPIO(gio_aon) is supported. 'Blinky' is the only sample that is working for now. Signed-off-by: Junho Lee <[email protected]> (cherry picked from commit 73f4102) Signed-off-by: Grygorii Strashko <[email protected]>

Enable serial communication through UART port between HDMI ports. Signed-off-by: Myeonghyeon Park <[email protected]> Signed-off-by: Junho Lee <[email protected]> (cherry picked from commit 63692c1) Signed-off-by: Grygorii Strashko <[email protected]>

Mainline zephyr is moved to HWM v2 which rearranged *soc* and *boards* which prevents usage of patches [1] as is. Hence backport bcm2712 to old HWM. Not for upstream. [1] zephyrproject-rtos#70538 Signed-off-by: Grygorii Strashko <[email protected]>

Mainline zephyr is moved to HWM v2 which rearranged *soc* and *boards* which prevents usage of patches [1] as is. Hence backport RPI5 board to old HWM. Not for upstream. [1] zephyrproject-rtos#70538 Signed-off-by: Grygorii Strashko <[email protected]>

The XEN events consume 72K of RAM, but they might be not used. Add XEN EVENTS Kconfig option so XEN events could be gracefully disabled if not needed. Signed-off-by: Grygorii Strashko <[email protected]>

The current "hypervisor" node defined to use 16M of MMIO memory, which is way too much. reduce it to 65K. Otherwise it's required to allocate bug number of grant frames for domain (max_grant_frames). As suggested by Dmytro Firsov. Signed-off-by: Grygorii Strashko <[email protected]>

The CONFIG_XEN_REGIONS is enabled by default, but second memory range is not defined for "hypervisor" node which causes build failure. Hence, disable CONFIG_XEN_REGIONS for xenvm platform. Signed-off-by: Grygorii Strashko <[email protected]>

Tmp adjust XEN_DOMCTL_INTERFACE_VERSION to start with XEN 4.19. See commit bdb1184d4f6bf4e0121fda34a6c1cb51fe270e7d ("domctl: bump interface version"), there were no Xen interface struct changes. Signed-off-by: Grygorii Strashko <[email protected]>

Add RPI5 board support. Signed-off-by: Grygorii Strashko <[email protected]>

Add rpi_5_xen_domd snippet to demonstrate enabling RPI 5 HW in Xen domain. Only GPIO LED is supported. Signed-off-by: Grygorii Strashko <[email protected]>

Add Xen specific documentation. Signed-off-by: Grygorii Strashko <[email protected]>

GrygiriiS requested review from lorc and firscity as code owners April 17, 2024 13:55

GrygiriiS force-pushed the zephyr-v3.6.0-xt-rpi5-dom0-wip branch from 293d630 to 0fce7ee Compare April 18, 2024 10:56

github-actions bot added manifest manifest-zephyr-xenlib DNM labels Apr 19, 2024

firscity reviewed Apr 22, 2024

View reviewed changes

GrygiriiS force-pushed the zephyr-v3.6.0-xt-rpi5-dom0-wip branch 2 times, most recently from f05c1a3 to 99a0bdc Compare April 26, 2024 13:40

github-actions bot removed manifest manifest-zephyr-xenlib DNM labels Apr 26, 2024

firscity reviewed Apr 29, 2024

View reviewed changes

GrygiriiS force-pushed the zephyr-v3.6.0-xt-rpi5-dom0-wip branch from 99a0bdc to fa8c762 Compare April 30, 2024 08:57

Deedone reviewed Apr 30, 2024

View reviewed changes

firscity force-pushed the rpi5_dev branch from e71da50 to bbdc9a3 Compare May 3, 2024 07:50

GrygiriiS requested a review from xakep-amatop as a code owner May 3, 2024 07:50

Lahyllas and others added 8 commits May 3, 2024 10:59

drivers: gpio: add brcmstb gpio driver

770ade1

Add GPIO driver for brcmstb, required by Raspberry Pi 5. Signed-off-by: Junho Lee <[email protected]> (cherry picked from commit 31badda) Signed-off-by: Grygorii Strashko <[email protected]>

soc: brcm: add support for BCM2712

cd0f8e3

Add support for BCM2712, SoC of Raspberry Pi 5. Signed-off-by: Junho Lee <[email protected]> (cherry picked from commit 76ec481) Signed-off-by: Grygorii Strashko <[email protected]>

soc: bcm2712: backport to old hwm

ae4aae6

Mainline zephyr is moved to HWM v2 which rearranged *soc* and *boards* which prevents usage of patches [1] as is. Hence backport bcm2712 to old HWM. Not for upstream. [1] zephyrproject-rtos#70538 Signed-off-by: Grygorii Strashko <[email protected]>

drivers: xen: add XEN_EVENTS Kconfig option

bce36aa

The XEN events consume 72K of RAM, but they might be not used. Add XEN EVENTS Kconfig option so XEN events could be gracefully disabled if not needed. Signed-off-by: Grygorii Strashko <[email protected]>

Grygorii Strashko added 5 commits May 3, 2024 10:59

snippets: xen_dom0: add rpi5 board

c8d922a

Add RPI5 board support. Signed-off-by: Grygorii Strashko <[email protected]>

snippets: add rpi_5_xen_domd to demo hw passing to xen domain

e8daa5b

Add rpi_5_xen_domd snippet to demonstrate enabling RPI 5 HW in Xen domain. Only GPIO LED is supported. Signed-off-by: Grygorii Strashko <[email protected]>

boards: arm64: rpi_5: add xen specific doc

dd6cfaf

Add Xen specific documentation. Signed-off-by: Grygorii Strashko <[email protected]>

GrygiriiS force-pushed the zephyr-v3.6.0-xt-rpi5-dom0-wip branch from fa8c762 to dd6cfaf Compare May 3, 2024 08:01

firscity merged commit 03c3eb6 into xen-troops:rpi5_dev May 3, 2024
9 checks passed

GrygiriiS deleted the zephyr-v3.6.0-xt-rpi5-dom0-wip branch May 9, 2024 11:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Zephyr v3.6.0 xt rpi5 dom0 wip #94

Zephyr v3.6.0 xt rpi5 dom0 wip #94

GrygiriiS commented Apr 17, 2024

GrygiriiS commented Apr 17, 2024

oleksiimoisieiev commented Apr 18, 2024

GrygiriiS commented Apr 18, 2024 •

edited

Loading

github-actions bot commented Apr 19, 2024 •

edited

Loading

firscity left a comment

GrygiriiS commented Apr 26, 2024

firscity Apr 29, 2024

firscity Apr 29, 2024

GrygiriiS Apr 30, 2024

Deedone Apr 30, 2024

GrygiriiS Apr 30, 2024

Deedone Apr 30, 2024

GrygiriiS Apr 30, 2024

Deedone Apr 30, 2024

GrygiriiS Apr 30, 2024

Deedone Apr 30, 2024

GrygiriiS Apr 30, 2024

		@@ -0,0 +1,17 @@
		.. _rpi_5_xen_domd:

		RPI 5 Xen DomD: snippet for XEN HW domain

Zephyr v3.6.0 xt rpi5 dom0 wip #94

Zephyr v3.6.0 xt rpi5 dom0 wip #94

Conversation

GrygiriiS commented Apr 17, 2024

GrygiriiS commented Apr 17, 2024

oleksiimoisieiev commented Apr 18, 2024

GrygiriiS commented Apr 18, 2024 • edited Loading

github-actions bot commented Apr 19, 2024 • edited Loading

firscity left a comment

Choose a reason for hiding this comment

GrygiriiS commented Apr 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GrygiriiS commented Apr 18, 2024 •

edited

Loading

github-actions bot commented Apr 19, 2024 •

edited

Loading