Add possibility to edit start/end time on entry

[akoppela]

Opening PR again. To summarize you don't want to have a variable reaper-hours-timer-mode but instead you want to automatically define what mode user is in, right? Also you want to update reaper--list-format based on mode, correct?

[xendk]

Hello again,

Here's what I want you to do: Rename reaper-edit-entry-time to reaper-edit-entry-time--duration and remove the (interactive). Copy that into reaper-edit-entry-time--start-end, and fix that to use start/end time instead. Create a new interactive reaper-edit-entry-time which just checks if start_time is set to determine which of the above to call.

That should make the editing Just Work™, and eliminates the possible error of having the wrong setting for users. Better user interface.

I don't know about reaper--list-format, what do you think? I wouldn't think it's particularly useful to show all the start/end times (I'd be more interested in the duration), but I'm not using start/end tracking. In any case, it'll require a bit more work for the listing to switch (I also think it could be useful if the listing was configurable to some extend) due to the nature of the tabulated-list view, so I think that qualifies for its own PR.

[akoppela]

Ok. Two functions make sense to me. I'll do that. Regarding `reaper--list-format` personally I'm fine with duration there. Harvest itself shows duration no matter what mode you're in. Thomas Fini Hansen ***@***.***> writes:

…

Hello again, Here's what I want you to do: Rename `reaper-edit-entry-time` to `reaper-edit-entry-time--duration` and remove the `(interactive)`. Copy that into `reaper-edit-entry-time--start-end`, and fix that to use start/end time instead. Create a new interactive `reaper-edit-entry-time` which just checks if start_time is set to determine which of the above to call. That should make the editing Just Work™, and eliminates the possible error of having the wrong setting for users. Better user interface. I don't know about `reaper--list-format`, what do you think? I wouldn't think it's particularly useful to show all the start/end times (I'd be more interested in the duration), but I'm not using start/end tracking. In any case, it'll require a bit more work for the listing to switch (I also think it could be useful if the listing was configurable to some extend) due to the nature of the tabulated-list view, so I think that qualifies for its own PR.

-- Thank you, Andrey

[xendk]

Excellent. 👍

We'll just leave the reaper--list-format as it is then.