XSO-926 Add Sangoma Linux to sed call #57
Conversation
samuelconnolly
force-pushed
the
master
branch
from
61b51c7
to
2a01fee
Compare
mk/xe-linux-distribution
Outdated
| @@ -150,6 +150,7 @@ identify_redhat() | |||
| -e 's/^Enterprise Linux Enterprise Linux .* release \([0-9]*\)\.\([0-9]*\) (.*)$/distro=oracle;major=\1;minor=\2;/gp;' \ | |||
| -e 's/^Enterprise Linux Enterprise Linux .* release \([0-9]*\) (.*)$/distro=oracle;major=\1/gp;' \ | |||
| -e 's/^Oracle Linux Server release \([0-9]*\)\.\([0-9]*\)$/distro=oracle;major=\1;minor=\2/gp;' \ | |||
| -e 's/^Sangoma Linux release \([0-9]*\)\.\([0-9]*\)\(\.[0-9]*\)\? (.*)/distro=centos;major=\1;minor=\2/gp;' \ | |||
There was a problem hiding this comment.
Is Sangoma distro = centos ? why not distro = sangoma?
There was a problem hiding this comment.
I believe it's because it's a modified CentOS distribution.
There was a problem hiding this comment.
I am not sure if a new verdor name should be added. The distro name is going to write into the xenstore.
See the previous newly added guests, a new distro will be added.
b467af0
Customer request - add FreePBX (Sangoma Linux) to Xenserver Tools detection, this was requested to prevent logs being flooded with tools not installed messages for this platform. Signed-off-by: Sam Connolly <[email protected]>
samuelconnolly
force-pushed
the
master
branch
from
2a01fee
to
55a76a2
Compare
|
|
The conflict must be resolved before a merge. |
|
I can provide a new PR that does not conflict and does add distro=sangoma instead of distro=centos, if considered useful. We already have this change in XCP-ng. |
Based on xenserver#57 Signed-Off-By: Samuel Verschelde <[email protected]>
Based on xenserver#57 Signed-Off-By: Samuel Verschelde <[email protected]>
Based on xenserver#57 Signed-off-by: Samuel Verschelde <[email protected]>
|
Sorry to jump in here with a comment, but what is the current status of this? It would be good if this could be fixed because the guest utilities installed with If you are using XCP-ng, the workaround is to install the agent from the guest tools ISO provided by XCP-ng as described here. |
|
Still seems to include conflicting |
Customer request - add FreePBX (Sangoma Linux) to Xenserver Tools
detection, this was requested to prevent logs being flooded with tools
not installed messages for this platform.
Signed-off-by: Sam Connolly [email protected]
https://bugs.xenserver.org/browse/XSO-926