Update xe-linux-distribution adding CloudLinux support

[frogstarr78]

The CloudLinux OS, which is based on CentOS, isn't detected properly by the xentools. This adjustment allows it to be.

[Zhengchai]

can you pls upload your testing result on which OS version number, testing results etc. please?
From the current supporting OS of Xen Hyper-visor, the CloudLinux OS was not on the supporting OS list, what is the benefit of adding this into?

[olivierlambert]

@Zhengchai you mean "supporting OS of Citrix Hypervisor" right? Because Xen Project itself works well with almost any Linux distro.

The benefit would be to allow CloudLinux to have working tools, even if it's not supported by Citrix, it doesn't mean it shouldn't be possible. Also, we would be happy to have this support upstream for XCP-ng project :)

[minli1]

Since we map the repo inside to build Citrix Hypervisor guest utilities, your changes may have an impact on us. In general, we added new guests support after have a full test on them. Anyway, please provide a screenshot or others to show it works well on Cloud Linux.
Probably in the future, we can change this repo more flexible to make others can fork and build by themselves. @olivierlambert

[olivierlambert]

Let us know what kind of tests you are requiring for tools to be sure it won't break anything, so we could run those and assist you on that: XCP-ng is sharing almost everything with Citrix Hypervisor, so it might be helpful to have common test requirements 👍

@frogstarr78 please share your results of using those modified tools to show it works, thanks!

[frogstarr78]

Let us know what kind of tests you are requiring for tools to be sure it won't break anything, so we could run those and assist you on that: XCP-ng is sharing almost everything with Citrix Hypervisor, so it might be helpful to have common test requirements

@frogstarr78 please share your results of using those modified tools to show it works, thanks!

I'm not sure I know exactly what is being asked for. Do you mean something like this?

[root@honeyberry ~]# cat /etc/redhat-release 
CloudLinux release 7.7 (Valery Bykovsky) 
[root@honeyberry ~]# systemctl restart xe-linux-distribution
[root@honeyberry ~]# systemctl status xe-linux-distribution
● xe-linux-distribution.service - Linux Guest Agent
   Loaded: loaded (/usr/lib/systemd/system/xe-linux-distribution.service; enabled; vendor preset: disabled)
   Active: active (running) since Wed 2019-09-11 17:08:02 PDT; 5s ago
  Process: 933798 ExecStartPre=/usr/sbin/xe-linux-distribution /var/cache/xe-linux-distribution (code=exited, status=0/SUCCESS)
  Process: 933795 ExecStartPre=/usr/sbin/sysctl net.ipv4.conf.all.arp_notify=1 (code=exited, status=0/SUCCESS)
 Main PID: 933805 (xe-daemon)
   CGroup: /system.slice/xe-linux-distribution.service
           ├─933805 /usr/sbin/xe-daemon
           ├─933810 logger -t xe-daemon
           └─933813 logger -t xenstore

Sep 11 17:08:02 honeyberry.viviotech.net systemd[1]: Starting Linux Guest Agent...
Sep 11 17:08:02 honeyberry.viviotech.net sysctl[933795]: net.ipv4.conf.all.arp_notify = 1
Sep 11 17:08:02 honeyberry.viviotech.net systemd[1]: Started Linux Guest Agent.
[root@honeyberry ~]# cat /var/cache/xe-linux-distribution 
os_distro="cloudlinux"
os_majorver="7"
os_minorver="7"
os_uname="3.10.0-962.3.2.lve1.5.26.2.el7.x86_64"
os_name="CloudLinux release 7.7 (Valery Bykovsky) "

and

[root@whortleberry ~]# cat /etc/redhat-release 
CloudLinux release 7.7 (Valery Bykovsky) 
[root@whortleberry ~]# systemctl restart xe-linux-distribution
[root@whortleberry ~]# systemctl status xe-linux-distribution
● xe-linux-distribution.service - Linux Guest Agent
   Loaded: loaded (/usr/lib/systemd/system/xe-linux-distribution.service; enabled; vendor preset: disabled)
   Active: active (running) since Wed 2019-09-11 17:49:58 PDT; 4s ago
  Process: 623233 ExecStartPre=/usr/sbin/xe-linux-distribution /var/cache/xe-linux-distribution (code=exited, status=0/SUCCESS)
  Process: 623230 ExecStartPre=/usr/sbin/sysctl net.ipv4.conf.all.arp_notify=1 (code=exited, status=0/SUCCESS)
 Main PID: 623240 (xe-daemon)
   CGroup: /system.slice/xe-linux-distribution.service
           ├─623240 /usr/sbin/xe-daemon
           ├─623245 logger -t xe-daemon
           └─623248 logger -t xenstore

Sep 11 17:49:58 whortleberry.viviotech.net systemd[1]: Starting Linux Guest Agent...
Sep 11 17:49:58 whortleberry.viviotech.net sysctl[623230]: net.ipv4.conf.all.arp_notify = 1
Sep 11 17:49:58 whortleberry.viviotech.net systemd[1]: Started Linux Guest Agent.
[root@whortleberry ~]# cat /var/cache/xe-linux-distribution
os_distro="cloudlinux"
os_majorver="7"
os_minorver="7"
os_uname="3.10.0-962.3.2.lve1.5.26.2.el7.x86_64"
os_name="CloudLinux release 7.7 (Valery Bykovsky) "

Is this the kind of thing you're requesting?

[Zhengchai]

Thanks. just confirm one more point - that you are aware of that you are running the 32bit Agent actually inside the x86_64 Guest OS (and it is by current xe-guest-utilities design, we will build 64bit agent in future per needs) - and you are OK with this? thanks

[frogstarr78]

Thanks. just confirm one more point - that you are aware of that you are running the 32bit Agent actually inside the x86_64 Guest OS (and it is by current xe-guest-utilities design, we will build 64bit agent in future per needs) - and you are OK with this? thanks

I'd rather run a 64-bit agent to match the OS architecture, but if there isn't one to install, then I don't have much of an option. So, yeah, that's fine.

[stormi]

We've had this change included into our own release of the guest tools for XCP-ng 8.2 for a few months with no particular issue.

[xihuan-citrix]

Hi @frogstarr78, could you help to resolve the conflicting?

[frogstarr78]

Hi @frogstarr78, could you help to resolve the conflicting?

Done