CA-384191: Fix missing values for min VM restrictions

- Min and max should also include the defaults when looking across all templates
- Ensure exception isn't hit unnecessarily when parsing restriction value for VMs
- Allow use of `GetRestrictionValueFromMatchingTemplate` with template objects
- Parallelize `GetRestrictionValueAcrossTemplates` call

Signed-off-by: Danilo Del Busso <[email protected]>

XenModel/XenAPI-Extensions/VM.cs

@@ -260,7 +260,10 @@ public int MinVCPUs()
         /// <returns>The value if found. If not found, null is returned instead</returns>
         private static T? GetRestrictionValueFromMatchingTemplate<T>(VM vm, string field, string attribute) where T : struct
         {
-            if (!vm.is_a_template && !string.IsNullOrEmpty(vm.reference_label))
+            if(vm.is_a_template)
+                return GetRestrictionValue<T>(vm, field, attribute);
+
+            if (!string.IsNullOrEmpty(vm.reference_label))
             {
                 var matchingTemplate = vm.Connection.Cache.VMs
                     .FirstOrDefault(v => v.is_a_template && v.reference_label == vm.reference_label);
@@ -288,6 +291,13 @@ public int MinVCPUs()
             var xn = xd?.SelectSingleNode($@"restrictions/restriction[@field='{field}']");
             var resultString = xn?.Attributes?[attribute]?.Value;
             T? result = null;
+
+            // avoid the expensive operation of throwing an exception
+            if (string.IsNullOrEmpty(resultString))
+            {
+                return null;
+            }
+
             try
             {
                 var converter = TypeDescriptor.GetConverter(typeof(T));
@@ -320,6 +330,7 @@ public int MinVCPUs()
         private static List<T> GetRestrictionValueAcrossTemplates<T>(IXenObject vm, string field, string attribute) where T : struct
         {
             return vm.Connection.Cache.VMs
+                .AsParallel()
                 .Where(v => v.is_a_template)
                 .Select(v => GetRestrictionValue<T>(v, field, attribute))
                 .Where(value => value != null)
@@ -343,6 +354,7 @@ private static T GetMaxRestrictionValue<T>(VM vm, string field, T defaultValue)
                 return (T) value;
 
             var templateValues = GetRestrictionValueAcrossTemplates<T>(vm, field, "max");
+            templateValues.Add(defaultValue);
             return templateValues.Count == 0 ? defaultValue : templateValues.Max();
         }
 
@@ -360,8 +372,8 @@ private static T GetMinRestrictionValue<T>(VM vm, string field, T defaultValue)
             var value = GetRestrictionValueFromMatchingTemplate<T>(vm, field, "min");
             if (value != null)
                 return (T)value;
-
             var templateValues = GetRestrictionValueAcrossTemplates<T>(vm, field, "min");
+            templateValues.Add(defaultValue);
             return templateValues.Count == 0 ? defaultValue : templateValues.Min();
         }