-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-40844: Adds download source action that gets the latest source code in the production stage #3153
CP-40844: Adds download source action that gets the latest source code in the production stage #3153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While making the changes for the source info to be fetched as part of the client updates XML, there's some low hanging fruits that can be changed even before that 👇
XenModel/BrandManager.cs
Outdated
@@ -31,6 +31,7 @@ | |||
using System.Diagnostics; | |||
using System.Reflection; | |||
using System.Resources; | |||
using System.Web.UI; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in BrandManager.cs and AssemblyInfo.cs are not needed since we're not introducing any new branded values. If I remember well we said we would be adding two new entries source_url
and source_checksum
in the XCupdates.xml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source_url yes but i thought we weren't bothered with the checksum on the source as it is just the source. We can though
@@ -3276,5 +3277,15 @@ private void toolStripMenuItemCfu_Click(object sender, EventArgs e) | |||
{ | |||
Updates.CheckForUpdates(true); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aplogies if I'm missing something, but why have we added two items?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one to be in the alert notification menu one to be in the help menu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna leave it at this for now, I'd rather wait for the merge conflicts to be addressed first as they're not super straight forward and I might just be commenting on stuff that's already been fixed on master
9967eab
to
f45025b
Compare
ed7b988
to
30f4753
Compare
…anager Signed-off-by: Chris Lancaster <[email protected]>
…me of the file Signed-off-by: Chris Lancaster <[email protected]>
Signed-off-by: Chris Lancaster <[email protected]>
Signed-off-by: Chris Lancaster <[email protected]>
Signed-off-by: Chris Lancaster <[email protected]>
…tead. Simplifies messages for source download and client update. Signed-off-by: Chris Lancaster <[email protected]>
Signed-off-by: Chris Lancaster <[email protected]>
Signed-off-by: Chris Lancaster <[email protected]>
…ction to handle disposal of FileStream Signed-off-by: Chris Lancaster <[email protected]>
Signed-off-by: Chris Lancaster <[email protected]>
Signed-off-by: Chris Lancaster <[email protected]>
…a where to save dialog Signed-off-by: Chris Lancaster <[email protected]>
…matic update checks are turned off. Renames message OUT_OF_DATE_WEBSITE to WEBSITE_DOWNLOADS Signed-off-by: Chris Lancaster <[email protected]>
Signed-off-by: Chris Lancaster <[email protected]>
…elevant places Signed-off-by: Chris Lancaster <[email protected]>
Signed-off-by: Chris Lancaster <[email protected]>
Signed-off-by: Chris Lancaster <[email protected]>
7d4aab0
to
91bd5e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made one or two more corrections and some refactorging. This is the commit: kc284@094bd18
If you add me as collaborator to your fork, I can send a PR directly and also add comments to explain the change.
Signed-off-by: Konstantina Chremmou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we squash this when we merge it.
… in the production stage.