UX improvements: CA-381442, XSI-1476, CA-375740

XenAdmin/Alerts/Types/OutOfSyncWithCdnAlert.cs

@@ -40,7 +40,7 @@ namespace XenAdmin.Alerts
 {
     public class OutOfSyncWithCdnAlert : Alert
     {
-        private readonly TimeSpan _outOfSyncSpan;
+        private readonly TimeSpan _outOfSyncSpan = TimeSpan.Zero;
         private readonly Pool _pool;
 
         private OutOfSyncWithCdnAlert(Pool pool, DateTime timestamp)
@@ -49,12 +49,19 @@ private OutOfSyncWithCdnAlert(Pool pool, DateTime timestamp)
             _pool = pool;
             Connection = _pool.Connection;
 
-            _outOfSyncSpan = _timestamp - _pool.last_update_sync;
+            if (pool.last_update_sync > Util.GetUnixMinDateTime())
+            {
+                _outOfSyncSpan = _timestamp - _pool.last_update_sync;
 
-            if (_outOfSyncSpan >= TimeSpan.FromDays(180))
-                Priority = AlertPriority.Priority1;
-            else if (_outOfSyncSpan >= TimeSpan.FromDays(90))
-                Priority = AlertPriority.Priority2;
+                if (_outOfSyncSpan >= TimeSpan.FromDays(180))
+                    Priority = AlertPriority.Priority1;
+                else if (_outOfSyncSpan >= TimeSpan.FromDays(90))
+                    Priority = AlertPriority.Priority2;
+            }
+            else
+            {
+                Priority = AlertPriority.Priority3;
+            }
         }
 
         public static bool TryCreate(IXenConnection connection, out Alert alert)
@@ -79,8 +86,9 @@ public static bool TryCreate(IXenConnection connection, out Alert alert)
 
         public override string AppliesTo => Helpers.GetName(_pool);
 
-        public override string Description => string.Format(Messages.ALERT_CDN_OUT_OF_SYNC_DESCRIPTION,
-            AlertExtensions.GetGuiDate(_pool.last_update_sync));
+        public override string Description => _outOfSyncSpan == TimeSpan.Zero
+            ? Messages.ALERT_CDN_NEVER_SYNC_TITLE
+            : string.Format(Messages.ALERT_CDN_OUT_OF_SYNC_DESCRIPTION, AlertExtensions.GetGuiDate(_pool.last_update_sync));
 
         public override Action FixLinkAction
         {
@@ -99,7 +107,9 @@ public override Action FixLinkAction
 
         public override string HelpID => "TODO";
 
-        public override string Title => string.Format(Messages.ALERT_CDN_OUT_OF_SYNC_TITLE, _outOfSyncSpan.Days);
+        public override string Title => _outOfSyncSpan == TimeSpan.Zero
+            ? Messages.ALERT_CDN_NEVER_SYNC_TITLE
+            : string.Format(Messages.ALERT_CDN_OUT_OF_SYNC_TITLE, _outOfSyncSpan.Days);
     }
 
 

XenAdmin/Dialogs/PropertiesDialog.cs

@@ -134,7 +134,7 @@ private void Build()
 
                 ShowTab(GeneralEditPage = new GeneralEditPage());
 
-                if (!isVmAppliance)
+                if (!isVmAppliance && !isVmss)
                     ShowTab(CustomFieldsEditPage = new CustomFieldsDisplayPage {AutoScroll = true});
 
                 if (isVm)

XenAdmin/Dialogs/ServerUpdates/ConfigCdnUpdatesPage.cs

@@ -85,8 +85,8 @@ private void ToggleConfigPanelEditState()
             buttonApply.Enabled = buttonDiscard.Enabled = active;
             comboBoxRepo.Enabled = active;
 
-            textBoxProxyUrl.ReadOnly = textBoxProxyUsername.ReadOnly = textBoxProxyPassword.ReadOnly = !active;
-            checkBoxPeriodicSync.Enabled = radioButtonDaily.Enabled = radioButtonWeekly.Enabled = comboBoxWeekday.Enabled = active;
+            textBoxProxyUrl.Enabled = textBoxProxyUsername.Enabled = textBoxProxyPassword.Enabled =
+                checkBoxPeriodicSync.Enabled = radioButtonDaily.Enabled = radioButtonWeekly.Enabled = comboBoxWeekday.Enabled = active;
 
             if (!active)
                 UpdateConfigPanel();

XenAdmin/Images.cs

@@ -971,6 +971,7 @@ public static class StaticImages
             public static Bitmap usb_16 = Properties.Resources.usb_16;
             public static Bitmap yinhekylin_16x = Properties.Resources.yinhekylin_16x;
             public static Bitmap rightArrowLong_Blue_16 = Properties.Resources.rightArrowLong_Blue_16;
+            public static Bitmap rpm_package = Properties.Resources.rpm_package;
         }
     }
 }

XenAdmin/Properties/Resources.resx

@@ -1156,4 +1156,7 @@
   <data name="livepatch_16" type="System.Resources.ResXFileRef, System.Windows.Forms">
     <value>..\Images\livepatch_16.png;System.Drawing.Bitmap, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
   </data>
-</root>
+  <data name="rpm_package" type="System.Resources.ResXFileRef, System.Windows.Forms">
+    <value>..\Images\rpm_package.png;System.Drawing.Bitmap, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
+  </data>
+</root>

XenAdmin/SettingsPanels/CustomFieldsDisplayPage.cs

@@ -342,7 +342,7 @@ private Label CreateNewLabel(CustomFieldDefinition customFieldDefinition)
                 return new Label
                 {
                     Anchor = AnchorStyles.Left | AnchorStyles.Right,
-                    Text = customFieldDefinition.Name.EscapeAmpersands().Ellipsise(25),
+                    Text = customFieldDefinition.Name.EscapeAmpersands().Ellipsise(45),
                     Font = Program.DefaultFont,
                     AutoSize = true,
                     AutoEllipsis = false

XenAdmin/TabPages/CdnUpdates/CdnExpandableRow.cs

@@ -249,7 +249,7 @@ internal class RpmCategoryRow : CdnExpandableRow
         public RpmCategoryRow(params string[] rpms)
         {
             SetValues(string.Format(Messages.HOTFIX_RPMS_TO_INSTALL, rpms.Length),
-                Images.StaticImages._000_Patch_h32bit_16);
+                Images.StaticImages.rpm_package);
 
             ChildRows = new List<CdnExpandableRow> { new RpmsRow(rpms) };
         }

XenAdmin/Wizards/PatchingWizard/PatchingWizard_ModePage.cs

@@ -168,12 +168,6 @@ public override bool EnableNext()
             return AutomaticRadioButton.Checked || ManualRadioButton.Checked;
         }
 
-        private void UpdateEnablement()
-        {
-            textBoxLog.Enabled = ManualRadioButton.Checked;
-            OnPageUpdated();
-        }
-
         #region Accessors
 
         public WizardMode WizardMode { get; set; }
@@ -196,12 +190,14 @@ private void UpdateEnablement()
 
         private void AutomaticRadioButton_CheckedChanged(object sender, EventArgs e)
         {
-            UpdateEnablement();
+            if (AutomaticRadioButton.Checked)
+                OnPageUpdated();
         }
 
         private void ManualRadioButton_CheckedChanged(object sender, EventArgs e)
         {
-            UpdateEnablement();
+            if (ManualRadioButton.Checked)
+                OnPageUpdated();
         }
 
         private void button1_Click(object sender, EventArgs e)

XenAdmin/XenAdmin.csproj

@@ -4575,6 +4575,7 @@
     <None Include="Images\saved_searches_24.png" />
     <None Include="Images\RunningDC_16.png" />
     <None Include="Images\rightArrowLong_Blue_16.png" />
+    <None Include="Images\rpm_package.png" />
     <Content Include="Images\save_to_disk.png" />
     <Content Include="Images\scilinux_16x.png" />
     <None Include="Images\server_32.png" />

XenModel/Messages.resx

@@ -1834,6 +1834,9 @@ This alarm is set to be triggered when the total throughput exceeds {4}.</value>
   <data name="ALERT_CAP_LABEL" xml:space="preserve">
     <value>(Showing first {0} entries)</value>
   </data>
+  <data name="ALERT_CDN_NEVER_SYNC_TITLE" xml:space="preserve">
+    <value>You have never synchronized with the update channel.</value>
+  </data>
   <data name="ALERT_CDN_OUT_OF_SYNC_DESCRIPTION" xml:space="preserve">
     <value>The last synchronization with the update channel took place on {0}.</value>
   </data>