Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tooltips with the original check names. #3245

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

kc284
Copy link
Contributor

@kc284 kc284 commented Oct 30, 2023

No description provided.

@@ -53,7 +53,7 @@ public class CheckGroup
public CheckGroup(string name, string labelName)
{
Name = name;
NameCell = new DataGridViewTextBoxCell { Value = labelName };
NameCell = new DataGridViewTextBoxCell { Value = labelName, ToolTipText = string.Format(Messages.NRPE_METRIC_TOOLTIP, name)};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But suggest to add a whitespace before the last brace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kc284 kc284 added the ASAP PR should be reviewed as soon as possible label Oct 30, 2023
@kc284 kc284 added the 1 approval PR has been approved by one reviewer label Oct 30, 2023
Signed-off-by: Konstantina Chremmou <[email protected]>
@danilo-delbusso danilo-delbusso added 2 approvals PR has been approved by two reviewers and removed 1 approval PR has been approved by one reviewer labels Nov 1, 2023
@kc284 kc284 merged commit 2e9c144 into xenserver:feature/nrpe Nov 1, 2023
1 check passed
@kc284 kc284 deleted the feature/nrpe branch November 1, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 approvals PR has been approved by two reviewers ASAP PR should be reviewed as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants