-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-43651, one inconsistency, layout tweaks, and minor refactoring on MultipleDvdIsoList. #3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantina Chremmou <[email protected]>
Signed-off-by: Konstantina Chremmou <[email protected]>
…rive. Signed-off-by: Konstantina Chremmou <[email protected]>
Signed-off-by: Konstantina Chremmou <[email protected]>
… operation was possible from the VmStorage TabPage. Signed-off-by: Konstantina Chremmou <[email protected]>
CitrixChris
approved these changes
Nov 6, 2023
danilo-delbusso
requested changes
Nov 13, 2023
danilo-delbusso
added
needs updating
A reviewer has requested changes
needs answer
PR contains question that needs to be answered
labels
Nov 13, 2023
Signed-off-by: Konstantina Chremmou <[email protected]>
kc284
added
updated
Changes completed, please review
and removed
needs updating
A reviewer has requested changes
needs answer
PR contains question that needs to be answered
labels
Nov 15, 2023
danilo-delbusso
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
danilo-delbusso
added
2 approvals
PR has been approved by two reviewers
and removed
1 approval
PR has been approved by one reviewer
updated
Changes completed, please review
labels
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inconsistency is in commit 81a2695
Commits best reviwed separately.