Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-384579: Call previous NRPE plugin xapi to resolve certs permission issue #3249

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

BengangY
Copy link
Contributor

@BengangY BengangY commented Nov 1, 2023

There is a bug caused by CA-384572. NRPE service can't start after RPU from Yangtze to XS 8 Stream.
The certificate used by NRPE which is generated in Yangtze has no permission. This leads the NRPE operation command (start, restart, etc) failed.
A workaround is that XenCenter sends 'control' command before NRPE enabled. ('control' will modify the permission of certificate)

@BengangY BengangY added the ASAP PR should be reviewed as soon as possible label Nov 1, 2023
@BengangY BengangY self-assigned this Nov 1, 2023
Copy link
Member

@danilo-delbusso danilo-delbusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only nit picky one

XenModel/Actions/NRPE/NRPEUpdateAction.cs Show resolved Hide resolved
@danilo-delbusso danilo-delbusso added the needs updating A reviewer has requested changes label Nov 1, 2023
@danilo-delbusso danilo-delbusso added 1 approval PR has been approved by one reviewer and removed needs updating A reviewer has requested changes labels Nov 1, 2023
@kc284 kc284 added the blocked PR is blocked on third-party or similar, do not review. label Nov 1, 2023
@kc284
Copy link
Contributor

kc284 commented Nov 1, 2023

Adding the "blocked" label until we decide whether the fix is needed.

@kc284 kc284 removed the blocked PR is blocked on third-party or similar, do not review. label Nov 2, 2023
@kc284 kc284 merged commit 90bcef3 into xenserver:feature/nrpe Nov 2, 2023
1 check passed
@danilo-delbusso danilo-delbusso added 2 approvals PR has been approved by two reviewers and removed 1 approval PR has been approved by one reviewer labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 approvals PR has been approved by two reviewers ASAP PR should be reviewed as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants