CA-368247 and CA-379225 #3257
Closed
CA-368247 and CA-379225 #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly as parent class for exporting snapshots and templates. Signed-off-by: Konstantina Chremmou <[email protected]>
…to file Win32.cs. Signed-off-by: Konstantina Chremmou <[email protected]>
- The export code was written from scratch instead of making use of the relevant http action exposed in the SDK. - The option to preserve a suspended VM's power state was not exposed. - Show percentage in the progress message. - Verification was happening twice (during download and after it). Signed-off-by: Konstantina Chremmou <[email protected]>
- Added image column to show the VM's power state. - Made the tick and image columns sortable. - Corrected sort logic for the size column. - Some refactoring to use a dedicated VmRow class. Signed-off-by: Konstantina Chremmou <[email protected]>
…b indices). Signed-off-by: Konstantina Chremmou <[email protected]>
… a suspended VM when exporting it as XVA. Signed-off-by: Konstantina Chremmou <[email protected]>
Signed-off-by: Konstantina Chremmou <[email protected]>
kc284
commented
Nov 20, 2023
| /// </summary> | ||
| /// <param name="path">An absolute path</param> | ||
| /// <exception cref="Exception">May be thrown</exception>> | ||
| public static DiskSpaceInfo GetDiskSpaceInfo(string path) |
There was a problem hiding this comment.
I moved this method closer to the file it is callwed from because I don't think it can be used in a wider context (attempt to use it in ExportSelectVMsPage.cs instead of Win32.GetDiskFreeSpaceEx causes a crash).
Signed-off-by: Konstantina Chremmou <[email protected]>
…omes first Signed-off-by: Konstantina Chremmou <[email protected]>
kc284
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review each commit separately.