Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force send on maximum byte size #28

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

force send on maximum byte size #28

wants to merge 5 commits into from

Conversation

fighterii
Copy link

@fighterii fighterii commented Dec 18, 2024 •
edited
Loading

First idea for #27

This checks for bytesize of logline when adding it to the buffer. Inside flush it is check multiple times (every 100ms) if a force_send is necessary.

@xente xente self-requested a review December 19, 2024 09:57
@xente xente added the bug Something isn't working label Dec 19, 2024
xente
xente requested changes Dec 21, 2024
View reviewed changes
loki_logger_handler/loki_logger_handler.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@xente xente added the enhancement New feature or request label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xente xente xente requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fighterii @xente