rename to Sorted.Create.Score due to the score interface

xh3b4sd · Sep 27, 2023 · e8053a9 · e8053a9
1 parent 6c522f7
commit e8053a9
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 18 deletions.
diff --git a/pkg/conformance/client_single_sorted_test.go b/pkg/conformance/client_single_sorted_test.go
@@ -157,30 +157,30 @@ func Test_Client_Single_Sorted_Create_Value(t *testing.T) {
 	}
 
 	{
-		err := cli.Sorted().Create().Value("ssk", "foo", 0.8)
+		err := cli.Sorted().Create().Score("ssk", "foo", 0.8)
 		if err != nil {
 			t.Fatal(err)
 		}
 	}
 
 	{
-		err := cli.Sorted().Create().Value("ssk", "bar", 0.7)
+		err := cli.Sorted().Create().Score("ssk", "bar", 0.7)
 		if err != nil {
 			t.Fatal(err)
 		}
 	}
 
 	// Verify we can create elements with duplicated scores.
 	{
-		err := cli.Sorted().Create().Value("ssk", "zap", 0.8)
+		err := cli.Sorted().Create().Score("ssk", "zap", 0.8)
 		if err != nil {
 			t.Fatal(err)
 		}
 	}
 
 	// Verify values must be unique after all.
 	{
-		err := cli.Sorted().Create().Value("ssk", "foo", 0.8)
+		err := cli.Sorted().Create().Score("ssk", "foo", 0.8)
 		if !sorted.IsAlreadyExistsError(err) {
 			t.Fatal("expected", "alreadyExistsError", "got", err)
 		}
@@ -656,19 +656,19 @@ func Test_Client_Single_Sorted_Delete_Value(t *testing.T) {
 	}
 
 	{
-		err = cli.Sorted().Create().Value("ssk", "foo", 8.0)
+		err = cli.Sorted().Create().Score("ssk", "foo", 8.0)
 		if err != nil {
 			t.Fatal(err)
 		}
-		err = cli.Sorted().Create().Value("ssk", "bar", 7.0)
+		err = cli.Sorted().Create().Score("ssk", "bar", 7.0)
 		if err != nil {
 			t.Fatal(err)
 		}
-		err = cli.Sorted().Create().Value("ssk", "baz", 6.0)
+		err = cli.Sorted().Create().Score("ssk", "baz", 6.0)
 		if err != nil {
 			t.Fatal(err)
 		}
-		err = cli.Sorted().Create().Value("ssk", "zap", 5.0)
+		err = cli.Sorted().Create().Score("ssk", "zap", 5.0)
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -1803,7 +1803,7 @@ func Test_Client_Single_Sorted_Update_Score(t *testing.T) {
 	}
 
 	{
-		err := cli.Sorted().Create().Value("ssk", "foo", 0.8)
+		err := cli.Sorted().Create().Score("ssk", "foo", 0.8)
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -1823,7 +1823,7 @@ func Test_Client_Single_Sorted_Update_Score(t *testing.T) {
 	}
 
 	{
-		err := cli.Sorted().Create().Value("ssk", "foo", 0.7)
+		err := cli.Sorted().Create().Score("ssk", "foo", 0.7)
 		if !sorted.IsAlreadyExistsError(err) {
 			t.Fatal("expected", "alreadyExistsError", "got", err)
 		}

diff --git a/pkg/fake/sorted_create.go b/pkg/fake/sorted_create.go
@@ -2,7 +2,7 @@ package fake
 
 type SortedCreate struct {
 	FakeIndex func() error
-	FakeValue func() error
+	FakeScore func() error
 }
 
 func (e *SortedCreate) Index(key string, val string, sco float64, ind ...string) error {
@@ -13,9 +13,9 @@ func (e *SortedCreate) Index(key string, val string, sco float64, ind ...string)
 	return nil
 }
 
-func (e *SortedCreate) Value(key string, val string, sco float64) error {
-	if e.FakeValue != nil {
-		return e.FakeValue()
+func (e *SortedCreate) Score(key string, val string, sco float64) error {
+	if e.FakeScore != nil {
+		return e.FakeScore()
 	}
 
 	return nil

diff --git a/pkg/sorted/create.go b/pkg/sorted/create.go
@@ -111,7 +111,7 @@ func (c *create) Index(key string, val string, sco float64, ind ...string) error
 	return tracer.Mask(executionFailedError)
 }
 
-func (c *create) Value(key string, val string, sco float64) error {
+func (c *create) Score(key string, val string, sco float64) error {
 	con := c.pool.Get()
 	defer con.Close()
 

diff --git a/pkg/sorted/interface.go b/pkg/sorted/interface.go
@@ -17,14 +17,13 @@ type Create interface {
 	// Scores are enforced to be unique.
 	Index(key string, val string, sco float64, ind ...string) error
 
-	// Value creates an element within the sorted set under key transparently
+	// Score creates an element within the sorted set under key transparently
 	// using ZADD and the NX option. Scores are not enforced to be unique, values
 	// are.
 	//
 	//     https://redis.io/commands/zadd
 	//
-	// TODO rename to Score due to its score interface
-	Value(key string, val string, sco float64) error
+	Score(key string, val string, sco float64) error
 }
 
 type Delete interface {