the embedbuilder can fail cause of bad recipes, catch it and remove t…

…hem from the db
xiaoxiao921 · Sep 20, 2021 · d86700b · d86700b
1 parent 1052979
commit d86700b
Showing 1 changed file with 20 additions and 1 deletion.
diff --git a/CHEF/Components/Commands/Cooking/CookModule.cs b/CHEF/Components/Commands/Cooking/CookModule.cs
@@ -50,12 +50,31 @@ private async Task ListRecipesInternal(SocketUser owner = null, int page = 1, st
             {
                 (recipes, totalRecipeCount) = await context.GetRecipes(cmdName, page - 1, owner);
             }
+
+            var badRecipes = new List<Recipe>();
             var embedBuilder = new EmbedBuilder();
             foreach (var recipe in recipes)
             {
                 var recipeText = recipe.Text;
                 var recipeTextLength = recipeText.Length > descMaxLength ? descMaxLength : recipeText.Length;
-                embedBuilder.AddField($"{recipe.Name}", $"{recipeText.Substring(0, recipeTextLength)}");
+
+                try
+                {
+                    embedBuilder.AddField($"{recipe.Name}", $"{recipeText.Substring(0, recipeTextLength)}");
+                }
+                catch (Exception)
+                {
+                    badRecipes.Add(recipe);
+                }
+            }
+
+            using (var context = new RecipeContext())
+            {
+                context.RemoveRange(badRecipes);
+
+                await context.SaveChangesAsync();
+
+                Logger.Log($"Removed {badRecipes.Count} bad recipes.");
             }
 
             if (recipes.Count > 0)