Skip to content

Commit

Permalink
misc: Enable Parquet Writer in Bucketed mode in TableWriterTest (face…
Browse files Browse the repository at this point in the history
…bookincubator#11852)

Summary:
facebookincubator#5560 has been resolved in PR facebookincubator#7025, so we can enable Parquet Writer in Bucketed mode in TableWriterTest.

CC: majetideepak

Pull Request resolved: facebookincubator#11852

Reviewed By: kagamiori

Differential Revision: D67304497

Pulled By: kgpai

fbshipit-source-id: 1733f260bddbd4a4d349a35e07951363f26cf51b
  • Loading branch information
wypb authored and facebook-github-bot committed Dec 17, 2024
1 parent e937db3 commit 9b77bd5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion velox/exec/tests/TableWriteTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1538,8 +1538,10 @@ class BucketSortOnlyTableWriterTest
static std::vector<uint64_t> getTestParams() {
std::vector<uint64_t> testParams;
const std::vector<bool> multiDriverOptions = {false, true};
// Add Parquet with https://github.com/facebookincubator/velox/issues/5560
std::vector<FileFormat> fileFormats = {FileFormat::DWRF};
if (hasWriterFactory(FileFormat::PARQUET)) {
fileFormats.push_back(FileFormat::PARQUET);
}
const std::vector<TestMode> bucketModes = {
TestMode::kBucketed, TestMode::kOnlyBucketed};
for (bool multiDrivers : multiDriverOptions) {
Expand Down

0 comments on commit 9b77bd5

Please sign in to comment.