New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breakpad support for cmake/vcpkg build #1628

Merged

xiaoyifang merged 1 commit into xiaoyifang:staged from shenlebantongying:feat/cmake-breakpad

Jul 3, 2024

Collaborator

shenlebantongying commented Jul 2, 2024 •

edited

Loading

Tested manually by inserting a throw std::runtime_error("whatever") and GD will create a dmp file successfully.

Unrelated known issues:

For some reason, vcpkg can no longer build the Windows version of dump_syms.exe/minidump_stackwalk.exe now. The needed tool has to be obtained from somewhere else.
The -llibbreakpad here is unneeded:

goldendict-ng/goldendict.pro

Line 81 in ddb9203

LIBS += -L$$PWD/thirdparty/breakpad/lib/ -llibbreakpad -llibbreakpad_client


          feat: breakpad support for cmake/vcpkg build

sonarqubecloud bot commented Jul 2, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

xiaoyifang merged commit fe2aa06 into xiaoyifang:staged

9 checks passed

shenlebantongying deleted the feat/cmake-breakpad branch

July 7, 2024 04:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet