Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new tts implementation #1685

Merged
merged 9 commits into from
Jul 17, 2024

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Jul 13, 2024

Tracking issue #1553

References:

Not really finished, but it works 😅

The API key will expire in a few days

We can talk coding problems in this PR, and design problems in the Issue?

@xiaoyifang
Copy link
Owner

xiaoyifang commented Jul 13, 2024

We can talk coding problems in this PR, and design problems in the Issue?

we can!

@shenlebantongying shenlebantongying changed the title feat: initial cloud tts feat: new tts implementation Jul 13, 2024
CMakeLists.txt Outdated Show resolved Hide resolved
MainLayout->addWidget( buttonBox, 2, 0, 1, 2 );
MainLayout->addWidget(
new QLabel(
R"(<font color="red">Experimental feature. The default API key may stop working at anytime. Feedback & Coding help are welcomed. </font>)",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave the Api key blank ,users should configure their own key.

@xiaoyifang
Copy link
Owner

xiaoyifang commented Jul 15, 2024

Offer user a way to stop playing the current selection . Especially when the selection is not soon to finish playing.

@shenlebantongying shenlebantongying marked this pull request as draft July 16, 2024 18:41
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@shenlebantongying shenlebantongying changed the base branch from staged to feat/ctts July 17, 2024 01:01
@shenlebantongying shenlebantongying marked this pull request as ready for review July 17, 2024 01:02
@shenlebantongying shenlebantongying merged commit 3ac6197 into xiaoyifang:feat/ctts Jul 17, 2024
7 of 8 checks passed
@shenlebantongying shenlebantongying deleted the feat/ctts branch July 17, 2024 01:06
@shenlebantongying shenlebantongying restored the feat/ctts branch July 17, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants