fix: respect the setting of QT_ENABLE_HIGHDPI_SCALING of the system #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting QT_ENABLE_HIGHDPI_SCALING to 1 might not work well in some cases. Instead of hard-coding it to 1, this commit checks if it is already set, and if it is empty or not set, then set it to 1. This allows overriding the QT_ENABLE_HIGHDPI_SCALING to 0 by respecting the system-wide setting of environment variables.
xiaoyifang
reviewed
Jan 13, 2025
…ENABLE_HIGHDPI_SCALING
xiaoyifang
approved these changes
Jan 14, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting QT_ENABLE_HIGHDPI_SCALING to 1 might not work well in some cases. Instead of hard-coding it to 1, this commit checks if it is already set, and if it is empty or not set, then set it to 1. This allows overriding the QT_ENABLE_HIGHDPI_SCALING to 0 by respecting the system-wide setting of environment variables.