Skip to content

Fix PHP deprecation warnings #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix PHP deprecation warnings #1215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea2d82e
Fix PHP deprecation warnings in menu.php
fxedel Nov 16, 2023
b05e5fd
Fix PHP deprecation warnings in class-path.php
fxedel Nov 16, 2023
e5ad36a
Merge pull request #1 from fxedel/patch-1
fxedel Nov 16, 2023
99424ab
Fix more deprecation notices
fxedel Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admin/menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function admin_menu() {
add_management_page( __( 'Manage Backups', 'backupwordpress' ), __( 'Backups', 'backupwordpress' ), ( defined( 'HMBKP_CAPABILITY' ) && HMBKP_CAPABILITY ) ? HMBKP_CAPABILITY : 'manage_options', HMBKP_PLUGIN_SLUG, 'HM\BackUpWordPress\manage_backups' );
}

add_submenu_page( null, __( 'BackUpWordPress Extensions', 'backupwordpress' ), __( 'Extensions', 'backupwordpress' ), ( defined( 'HMBKP_CAPABILITY' ) && HMBKP_CAPABILITY ) ? HMBKP_CAPABILITY : 'manage_options', HMBKP_PLUGIN_SLUG . '_extensions', 'HM\BackUpWordPress\extensions' );
add_submenu_page('options.php', __( 'BackUpWordPress Extensions', 'backupwordpress' ), __( 'Extensions', 'backupwordpress' ), ( defined( 'HMBKP_CAPABILITY' ) && HMBKP_CAPABILITY ) ? HMBKP_CAPABILITY : 'manage_options', HMBKP_PLUGIN_SLUG . '_extensions', 'HM\BackUpWordPress\extensions' );

}
add_action( 'network_admin_menu', 'HM\BackUpWordPress\admin_menu' );
Expand Down
2 changes: 1 addition & 1 deletion classes/class-path.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ public function cleanup() {
class CleanUpIterator extends \FilterIterator {

// Don't match index.html, files with zip extension or status logfiles.
public function accept() {
public function accept(): bool {

// Don't remove existing backups
if ( 'zip' === pathinfo( $this->current()->getFilename(), PATHINFO_EXTENSION ) ) {
Expand Down
9 changes: 9 additions & 0 deletions classes/class-scheduled-backup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,15 @@ class Scheduled_Backup {
*/
private $slug = '';

/** @var string|null */
private $backup_filename = NULL;

/** @var string|null */
private $database_dump_filename = NULL;

/** @var Backup_Status|null */
private $status = NULL;

/**
* The raw schedule options from the database
*
Expand Down