-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements of UI. #35
Conversation
@@ -0,0 +1,2363 @@ | |||
/*! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this file? You only seem to reference bootstrap.min.js
Same goes for |
By the way: thanks! Great to have members contribute to this. Hope we can make it easier and better. |
Hi, in fact I just putted the whole bootstrap package but havn't removed the unused files. |
Could you remove the unused parts? Ideally, clean out the .css to remove the unreferenced parts. There's tools for that (although I can't remember them now). |
@rngadam Can you review this and |
Yes I can remove the unminified files from the repository. Concerning the unreferenced parts, I never heard about a tools for that, and it's really hard to do with dynamic web pages. The bootstrap framework is a framework, and like all the framework it's not designed to be separated. For futur evolutions, it's better to keep it complete. |
Looks good! |
Hi all,
I'm a new member of XinCheJian and I saw that we are able to fork the project... So that's what I did and I hope you will enjoy that ;-)
Regards,