Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements of UI. #35

Merged
merged 3 commits into from
Oct 18, 2015
Merged

Improvements of UI. #35

merged 3 commits into from
Oct 18, 2015

Conversation

mermetbt
Copy link
Contributor

Hi all,
I'm a new member of XinCheJian and I saw that we are able to fork the project... So that's what I did and I hope you will enjoy that ;-)
Regards,

@@ -0,0 +1,2363 @@
/*!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this file? You only seem to reference bootstrap.min.js

@lionello
Copy link
Member

Same goes for bootstrap.css, only seems to be using the minified version.

@lionello
Copy link
Member

By the way: thanks! Great to have members contribute to this. Hope we can make it easier and better.

@mermetbt
Copy link
Contributor Author

Hi, in fact I just putted the whole bootstrap package but havn't removed the unused files.

@lionello
Copy link
Member

Could you remove the unused parts? Ideally, clean out the .css to remove the unreferenced parts. There's tools for that (although I can't remember them now).

@lionello
Copy link
Member

@rngadam Can you review this and git pull in /var/www if OK?

@lionello
Copy link
Member

Guys, don't let this good work left unused.
@rngadam Can you review after deploying?
@mermetbt Can you address my concern, i.e. remove unused files?

@mermetbt
Copy link
Contributor Author

Yes I can remove the unminified files from the repository.

Concerning the unreferenced parts, I never heard about a tools for that, and it's really hard to do with dynamic web pages. The bootstrap framework is a framework, and like all the framework it's not designed to be separated. For futur evolutions, it's better to keep it complete.

lionello added a commit that referenced this pull request Oct 18, 2015
@lionello lionello merged commit f702e86 into xinchejian:master Oct 18, 2015
@lionello
Copy link
Member

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants