Suppress error for bad implementations of Comparable

RELNOTES=N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=236248361
xinchentechnote · Mar 7, 2019 · c371307 · c371307
1 parent dcaf893
commit c371307
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 0 deletions.
diff --git a/android/guava-testlib/src/com/google/common/testing/ArbitraryInstances.java b/android/guava-testlib/src/com/google/common/testing/ArbitraryInstances.java
@@ -468,6 +468,7 @@ public OutputStream openStream() {
   // Compare by toString() to satisfy 2 properties:
   // 1. compareTo(null) should throw NullPointerException
   // 2. the order is deterministic and easy to understand, for debugging purpose.
+  @SuppressWarnings("ComparableType")
   private static final class ByToString implements Comparable<Object>, Serializable {
     private static final ByToString INSTANCE = new ByToString();
 

diff --git a/android/guava-tests/test/com/google/common/collect/LegacyComparable.java b/android/guava-tests/test/com/google/common/collect/LegacyComparable.java
@@ -27,6 +27,7 @@
  *
  * @author Kevin Bourrillion
  */
+@SuppressWarnings("ComparableType")
 @GwtCompatible
 class LegacyComparable implements Comparable, Serializable {
   static final LegacyComparable X = new LegacyComparable("x");

diff --git a/android/guava-tests/test/com/google/common/graph/ElementOrderTest.java b/android/guava-tests/test/com/google/common/graph/ElementOrderTest.java
@@ -239,6 +239,7 @@ public String toString() {
     }
   }
 
+  @SuppressWarnings("ComparableType")
   private static class ComparableSubClass extends NonComparableSuperClass
       implements Comparable<NonComparableSuperClass> {
 

diff --git a/guava-testlib/src/com/google/common/testing/ArbitraryInstances.java b/guava-testlib/src/com/google/common/testing/ArbitraryInstances.java
@@ -480,6 +480,7 @@ public OutputStream openStream() {
   // Compare by toString() to satisfy 2 properties:
   // 1. compareTo(null) should throw NullPointerException
   // 2. the order is deterministic and easy to understand, for debugging purpose.
+  @SuppressWarnings("ComparableType")
   private static final class ByToString implements Comparable<Object>, Serializable {
     private static final ByToString INSTANCE = new ByToString();
 

diff --git a/guava-tests/test/com/google/common/collect/LegacyComparable.java b/guava-tests/test/com/google/common/collect/LegacyComparable.java
@@ -27,6 +27,7 @@
  *
  * @author Kevin Bourrillion
  */
+@SuppressWarnings("ComparableType")
 @GwtCompatible
 class LegacyComparable implements Comparable, Serializable {
   static final LegacyComparable X = new LegacyComparable("x");

diff --git a/guava-tests/test/com/google/common/graph/ElementOrderTest.java b/guava-tests/test/com/google/common/graph/ElementOrderTest.java
@@ -239,6 +239,7 @@ public String toString() {
     }
   }
 
+  @SuppressWarnings("ComparableType")
   private static class ComparableSubClass extends NonComparableSuperClass
       implements Comparable<NonComparableSuperClass> {
-Original file line number
+Diff line change
@@ Expand Up / @@ -239,6 +239,7 @@ public String toString() { @@
         }
       }
+      @SuppressWarnings("ComparableType")
       private static class ComparableSubClass extends NonComparableSuperClass
           implements Comparable<NonComparableSuperClass> {
@@ Expand Down @@