fix check

xinlifoobar · Aug 20, 2024 · d5b63f4 · d5b63f4
1 parent ee23b97
commit d5b63f4
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/datafusion/functions/src/regex/regexpcount.rs b/datafusion/functions/src/regex/regexpcount.rs
@@ -305,12 +305,6 @@ fn regex_iter_count<'a>(
                     return Ok(0);
                 }
 
-                if regex.contains('g') {
-                    return Err(ArrowError::ComputeError(
-                        "regexp_count() does not support global flag".to_string(),
-                    ));
-                }
-
                 if start <= 0 {
                     return Err(ArrowError::ComputeError(
                         "regexp_count() requires start to be 1 based".to_string(),
@@ -326,6 +320,12 @@ fn regex_iter_count<'a>(
                 let pattern = if let Some(Some(flags)) =
                     flags.map(|x| if x.is_empty() { None } else { Some(x) })
                 {
+                    if flags.contains('g') {
+                        return Err(ArrowError::ComputeError(
+                            "regexp_count() does not support global flag".to_string(),
+                        ));
+                    }
+
                     format!("(?{flags}){regex}")
                 } else {
                     regex.to_string()