Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake Doxygen install (match Makefile builds) #685

Merged

Conversation

jevinskie
Copy link
Contributor

The CMake install was trying to install <gitroot>/docs/api/ instead of <buildroot>/docs/doxytemp/. Matches Makefile behavior.

@ktmf01
Copy link
Collaborator

ktmf01 commented Apr 3, 2024

Diving into this, I see now that CMake Doxygen installing is broken anyway, but this patch would make installing from a tarball even more broken.

It would probably be better to have a post build hook to rename the doxytmp/html directory to api. That is what the makefile does, so that would truely match it.

Note to self: Currently api docs are only installed when doxygen is detected, in which case they are rebuild anyway. The return here probably needs a little more sophistication.

@ktmf01 ktmf01 merged commit d6204ea into xiph:master Jun 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make install appears to not generate required docs or the install command is outdated.
2 participants