Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another endless loop in chained ogg handling #772

Merged
merged 1 commit into from
Dec 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/libFLAC/ogg_decoder_aspect.c
Original file line number Diff line number Diff line change
Expand Up @@ -646,8 +646,14 @@ FLAC__OggDecoderAspectReadStatus FLAC__ogg_decoder_aspect_skip_link(FLAC__OggDec
/* We read from the left_pos but found nothing interesting, so we can move left_pos up */
left_pos = current_pos;
}
else if(did_a_seek)
right_pos = page_pos;
else if(did_a_seek) {
if(right_pos <= page_pos) {
/* Ended up somewhere we've already been */
seek_to_left_pos = true;
}
else
right_pos = page_pos;
}
else {
/* Read forward but found an unknown serial number */
return FLAC__OGG_DECODER_ASPECT_READ_STATUS_ERROR;
Expand Down
Loading