fix: remove need for explicit include path /usr/local/opus

[braindigitalis]

This is not the way parent headers are supposed to be included. This has been an issue for years and nobody raised a PR yet, so i'm raising one.

[C0rn3j]

@rillian @erikd @jmvalin @MisterZeus @phschafft @smarter @tmatth

Could anyone please merge this and tag a release?

This has been an issue with a simple fix available for over 6 years - #10

There's similarly easy-to-deal-with PRs in this repository but this one is the one that keeps biting me over and over.

---

I need to keep silly workarounds for every single platform because of this:

include-dirs = ["/usr/include/opus", "/opt/homebrew/include/opus", "C:/msys64/mingw64/include/opus"]

And I still get bit by it anyway the moment I change my env a little -

In file included from src/phazor/phazor.c:72:
D:/a/_temp/msys64/mingw64/include/opus/opusfile.h:110:11: fatal error: opus_multistream.h: No such file or directory
  110 | # include <opus_multistream.h>
      |           ^~~~~~~~~~~~~~~~~~~~

PR should have
Fixes #41

[braindigitalis]

I think this library is unfortunately dead.

[C0rn3j]

xiph maintains opus itself too, so I am hopeful someone gets to it, although right now it's holiday season so it may take a couple weeks.

[tmatth]

@rillian @erikd @jmvalin @MisterZeus @phschafft @smarter @tmatth

Could anyone please merge this and tag a release?

This has been an issue with a simple fix available for over 6 years - #10

As @tterribe already explained this is working as intended.

Plenty of third party projects which build on multiple OSes have no problem including opus_multistream as is (see e.g., VLC or ffmpeg) It's up to your build system to ensure the include path is correct (e.g. using pkg-config --cflags).

[C0rn3j]

And as pointed out in a comment below that one, xiph is working around this issue by using double quotes in opus.

Wouldn't it then be better to use double quotes here too, and wouldn't it resolve the issue for everyone without any impact and changing import paths?

[braindigitalis]

if everyone else is saying it's broken, perhaps they are right?