Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dark70p_60f to dark720p_60f #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rzumer
Copy link
Collaborator

@rzumer rzumer commented Dec 3, 2019

There is an error in the name, which can be confusing.
In the current version of objective-1-fast, the file name is
the correct one, so deploying AWCY and running on this
set will generate errors unless the file is renamed.

In some sets the name was already correct, in others the error is present, which is also confusing.

With this change the AWCY back-end will need to have its files renamed in the affected sets.

There is an error in the name, which can be confusing.
In the current version of objective-1-fast, the file name is
the correct one, so deploying AWCY and running on this
set will generate errors unless the file is renamed.
@tdaede
Copy link
Collaborator

tdaede commented Apr 30, 2020

This breaks viewing historical runs with the old naming. I think some sort of workaround would be needed for that.

@rzumer
Copy link
Collaborator Author

rzumer commented Aug 24, 2020

I think keeping the current sets.json on the main AWCY instances is fine, but this should be merged so new instances use the correct name, otherwise it will never get fixed. Since it's not possible to directly compare runs between instances I think that's a minor concern in comparison. Besides the name being wrong and potentially confusing, it's an annoyance when deploying AWCY because the file in objective-1-fast must be renamed (or the sets file manually corrected) as part of deployment or will cause runs to fail.

@rzumer
Copy link
Collaborator Author

rzumer commented Nov 20, 2020

I still want to merge this to make deployment of new AWCY instances not require changing the filename manually. IMO the current instance can keep its sets.json file as-is if we want to be able to compare with old runs, but that shouldn't block an error from being fixed. Is there any other reason not to proceed?

@vibhoothi
Copy link
Collaborator

vibhoothi commented Apr 15, 2021

Hi,
I was trying to deploy AWCY instance locally, I also faced the same issue, I ended up creating two copies of the file in ~/awcy/media/objective-1-fast/
I was thinking will it be possible to have such hack-around and have proper filename for future builds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants