Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/id #554

Merged
merged 11 commits into from
Dec 19, 2023
Merged

Refactor/id #554

merged 11 commits into from
Dec 19, 2023

Conversation

iGxnon
Copy link
Contributor

@iGxnon iGxnon commented Nov 30, 2023

I accidentally deleted the repository I forked. Reopen of #533

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (fa656ad) 64.40% compared to head (fae28d0) 78.91%.
Report is 9 commits behind head on master.

Files Patch % Lines
curp/src/client.rs 85.71% 2 Missing ⚠️
curp/src/rpc/mod.rs 95.83% 2 Missing ⚠️
curp/src/server/raw_curp/mod.rs 96.82% 2 Missing ⚠️
curp-external-api/src/role_change.rs 0.00% 1 Missing ⚠️
curp/src/log_entry.rs 95.45% 1 Missing ⚠️
...urp/src/server/cmd_worker/conflict_checked_mpmc.rs 90.00% 1 Missing ⚠️
curp/src/server/mod.rs 66.66% 1 Missing ⚠️
xline/src/server/kv_server.rs 83.33% 1 Missing ⚠️
xline/src/server/lock_server.rs 0.00% 1 Missing ⚠️
xline/src/storage/compact/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #554       +/-   ##
===========================================
+ Coverage   64.40%   78.91%   +14.50%     
===========================================
  Files         105      154       +49     
  Lines       18802    21192     +2390     
  Branches    18802        0    -18802     
===========================================
+ Hits        12109    16723     +4614     
+ Misses       5955     4469     -1486     
+ Partials      738        0      -738     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Phoenix500526 Phoenix500526 added this to the v0.6.1 milestone Dec 1, 2023
@iGxnon iGxnon force-pushed the refactor/id branch 3 times, most recently from 9bfc346 to 9786975 Compare December 13, 2023 07:32
@iGxnon iGxnon marked this pull request as ready for review December 13, 2023 07:32
@iGxnon iGxnon force-pushed the refactor/id branch 3 times, most recently from 7586c6a to 1e0dce3 Compare December 18, 2023 02:47
curp/src/rpc/mod.rs Outdated Show resolved Hide resolved
curp/src/server/cmd_worker/mod.rs Outdated Show resolved Hide resolved
curp/src/server/raw_curp/mod.rs Show resolved Hide resolved
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iGxnon iGxnon merged commit 252aa55 into xline-kv:master Dec 19, 2023
9 checks passed
@iGxnon iGxnon deleted the refactor/id branch December 19, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants