Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update xline pod of ci,add probe,volume and security config. #745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: update xline pod of ci,add probe,volume and security config. #745

wants to merge 1 commit into from

Conversation

liangyuanpeng
Copy link
Contributor

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

The content is basically copied from etcd pod yaml,happy to update it if we have better config.

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@codecov Codecov
Copy link

codecov bot commented Mar 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.13%. Comparing base (e35b35a) to head (5a00680).
Report is 49 commits behind head on master.

❗ Current head 5a00680 differs from pull request most recent head 6cc1026. Consider uploading reports for the commit 6cc1026 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
- Coverage   75.55%   75.13%   -0.42%     
==========================================
  Files         180      176       -4     
  Lines       26938    26852      -86     
  Branches    26938    26852      -86     
==========================================
- Hits        20353    20176     -177     
- Misses       5366     5465      +99     
+ Partials     1219     1211       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangyuanpeng liangyuanpeng marked this pull request as draft March 30, 2024 14:59
@liangyuanpeng liangyuanpeng marked this pull request as ready for review March 30, 2024 15:35
liangyuanpeng
liangyuanpeng commented Apr 1, 2024
View reviewed changes
ci/artifacts/xline-pod.yaml
failureThreshold: 24
httpGet:
host: 127.0.0.1
path: /metrics
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably requires a better one, but I haven't found one. Remind me if i missed something,Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, this requires the application to have /readyz and /livez interfaces. etcd is also implement the grpc for it etcd-io/etcd@293f087#diff-ab6fb0684315e16355f6ebe0f4b3cf860b9b2ff5a0fe1b4e4308a680b19f1b0c

@liangyuanpeng
Copy link
Contributor Author

cc @Phoenix500526 @bsbds
PTAL,Thanks.

@mergify mergify bot requested a review from a team April 19, 2024 04:37
@liangyuanpeng
Copy link
Contributor Author

kindly ping :)

@liangyuanpeng liangyuanpeng mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liangyuanpeng