Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ruct toolchain version from 1.71.0 to 1.74.0 #758

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Phoenix500526
Copy link
Collaborator

@Phoenix500526 Phoenix500526 commented Apr 7, 2024

Please briefly answer these questions:
Depends-On: #776

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    bump rustc toolchain version from 1.71.0 to 1.74.0

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@Phoenix500526 Phoenix500526 force-pushed the toolchain/upgrade-1.74 branch 7 times, most recently from beaabe2 to 19f71f9 Compare April 9, 2024 03:21
GFX9
GFX9 previously approved these changes Apr 9, 2024
crates/benchmark/src/lib.rs Outdated Show resolved Hide resolved
crates/curp-external-api/src/cmd.rs Outdated Show resolved Hide resolved
crates/curp-test-utils/src/test_cmd.rs Show resolved Hide resolved
crates/curp/src/client/stream.rs Outdated Show resolved Hide resolved
crates/curp/src/client/tests.rs Outdated Show resolved Hide resolved
crates/curp/src/server/cmd_worker/mod.rs Show resolved Hide resolved
crates/curp/src/server/curp_node.rs Show resolved Hide resolved
crates/curp/src/server/curp_node.rs Outdated Show resolved Hide resolved
@Phoenix500526 Phoenix500526 force-pushed the toolchain/upgrade-1.74 branch 4 times, most recently from c6f9b03 to f62e9f2 Compare April 16, 2024 14:40
@xline-kv xline-kv deleted a comment from codecov bot Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 69.90291% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 75.39%. Comparing base (e35b35a) to head (f62e9f2).
Report is 18 commits behind head on master.

❗ Current head f62e9f2 differs from pull request most recent head 7b5d112. Consider uploading reports for the commit 7b5d112 to get more accurate results

Files Patch % Lines
crates/xline/src/utils/args.rs 0.00% 18 Missing ⚠️
crates/engine/src/rocksdb_engine/mod.rs 84.21% 3 Missing and 6 partials ⚠️
crates/xline/src/storage/auth_store/store.rs 50.00% 6 Missing ⚠️
crates/curp/src/server/curp_node.rs 84.37% 5 Missing ⚠️
crates/xlinectl/src/command/watch.rs 0.00% 5 Missing ⚠️
crates/curp/src/rpc/mod.rs 72.72% 3 Missing ⚠️
crates/curp/src/server/storage/db.rs 75.00% 2 Missing ⚠️
crates/xline/src/metrics.rs 0.00% 2 Missing ⚠️
crates/xline/src/storage/lease_store/mod.rs 50.00% 2 Missing ⚠️
crates/curp-test-utils/src/test_cmd.rs 90.90% 0 Missing and 1 partial ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
- Coverage   75.55%   75.39%   -0.17%     
==========================================
  Files         180      182       +2     
  Lines       26938    26995      +57     
  Branches    26938    26995      +57     
==========================================
- Hits        20353    20352       -1     
- Misses       5366     5381      +15     
- Partials     1219     1262      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/benchmark/src/lib.rs Show resolved Hide resolved
crates/curp/src/client/stream.rs Show resolved Hide resolved
crates/curp/src/server/curp_node.rs Show resolved Hide resolved
@mergify mergify bot merged commit 0e4e3d1 into xline-kv:master Apr 18, 2024
12 checks passed
@Phoenix500526 Phoenix500526 deleted the toolchain/upgrade-1.74 branch May 12, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants