Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delay behavior in Controller #4

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Fix delay behavior in Controller #4

wants to merge 23 commits into from

Conversation

lxl66566
Copy link
Collaborator

@lxl66566 lxl66566 commented Sep 1, 2024

Depends-On: #3

In previous Controller design, every generators will take one DelayStrategy, it will delays on each next() call.
If i convert a GeneratorGroup into Generator, the new Generator will take the DelayStrategy of the first generator in the group. If there's different DelayStrategy in the group, it will be lost.

The solution is to make DelayStrategy as an Iterator that contains a sequence of each DelayStrategys, in the same amount of generator op sequence. So when converting GeneratorGroup into Generator, the DelayStrategys will be chained and will not lost.

This change is based on that an op sequence in the generator must be finite.

Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
@lxl66566 lxl66566 mentioned this pull request Sep 25, 2024
@lxl66566 lxl66566 marked this pull request as draft October 11, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant