CI: Missing dependencies #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you @me00001 @hamirmahal 🙏 |
|
You're welcome @xlmnxp. |
hamirmahal
reviewed
Jun 4, 2024
Comment on lines
11
to
+22
| sudo apt-get install \ | ||
| librust-gstreamer-sys-dev \ | ||
| librust-gtk4-sys-dev \ | ||
| libunwind-dev | ||
| libunwind-dev \ | ||
| librust-gstreamer-sys-dev \ | ||
| librust-gdk-sys-dev \ | ||
| librust-atk-dev \ | ||
| librust-gtk4-sys-dev \ | ||
| libgdk-pixbuf-2.0-dev \ | ||
| librust-pango-dev \ | ||
| librust-gobject-sys-dev \ | ||
| ffmpeg |
There was a problem hiding this comment.
This seems to work with just
sudo apt-get install \
librust-gdk-sys-dev \
librust-gtk4-sys-dev \
librust-gstreamer-sys-dev \
libunwind-dev
|
https://github.com/hamirmahal/blue-recorder/commit/b798069dccce5f10ea85749ef17f2c9ab1abcd84 is the commit that works with just sudo apt-get install \
librust-gdk-sys-dev \
librust-gtk4-sys-dev \
librust-gstreamer-sys-dev \
libunwind-devI will probably delete that branch soon. We may want to simplify the dependencies to just these four, to speed up CI workflow times and reduce code complexity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#67 (comment)