Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace get(0) with cleaner first() #75

Merged
merged 2 commits into from
Jun 30, 2024
Merged

refactor: replace get(0) with cleaner first() #75

merged 2 commits into from
Jun 30, 2024

Conversation

hamirmahal
Copy link
Contributor

No description provided.

hamirmahal
hamirmahal commented Jun 30, 2024
View reviewed changes
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes in this pull request are from formatting.

We should probably leverage cargo fmt to reduce noise in diffs.

@xlmnxp xlmnxp merged commit 2bc71a8 into xlmnxp:master Jun 30, 2024
2 checks passed
@xlmnxp
Copy link
Owner

xlmnxp commented Jun 30, 2024

@hamirmahal I agree with you, I will add something like Code Lint to force the format

@xlmnxp
Copy link
Owner

xlmnxp commented Jun 30, 2024

also, thank you for your contribution 👍

@hamirmahal
Copy link
Contributor Author

You're welcome!

@hamirmahal hamirmahal deleted the refactor/replace-get-0-with-first branch June 30, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamirmahal @xlmnxp