Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/allow source in validators #271

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

johnabass
Copy link
Contributor

A validation refactoring that allows much more flexible and simpler validation code.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.32%. Comparing base (85e0935) to head (3336041).
Report is 27 commits behind head on main.

Files Patch % Lines
basculehttp/middleware.go 57.14% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #271       +/-   ##
===========================================
+ Coverage   32.74%   67.32%   +34.58%     
===========================================
  Files          15       14        -1     
  Lines         452      456        +4     
===========================================
+ Hits          148      307      +159     
+ Misses        304      141      -163     
- Partials        0        8        +8     
Flag Coverage Δ
unittests 67.32% <97.43%> (+34.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnabass johnabass merged commit 5a5aa08 into main Jul 30, 2024
18 checks passed
@johnabass johnabass deleted the feature/allow-source-in-validators branch July 30, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant