Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove credentials #272

Merged
merged 6 commits into from
Aug 6, 2024

use the new parsing interface

4bcfc4e
Select commit
Loading
Failed to load commit list.
Merged

Feature/remove credentials #272

use the new parsing interface
4bcfc4e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 5, 2024 in 0s

67.84% (+0.52%) compared to 5a5aa08

View this Pull Request on Codecov

67.84% (+0.52%) compared to 5a5aa08

Details

Codecov Report

Attention: Patch coverage is 71.12676% with 41 lines in your changes missing coverage. Please review.

Project coverage is 67.84%. Comparing base (5a5aa08) to head (4bcfc4e).

Files Patch % Lines
basculehttp/authorization.go 67.44% 10 Missing and 4 partials ⚠️
basculehttp/scheme.go 36.36% 7 Missing ⚠️
basculehttp/basic.go 64.70% 6 Missing ⚠️
basculehttp/error.go 50.00% 4 Missing ⚠️
basculehttp/middleware.go 75.00% 3 Missing and 1 partial ⚠️
basculejwt/token.go 0.00% 4 Missing ⚠️
basculehttp/challenge.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   67.32%   67.84%   +0.52%     
==========================================
  Files          14       12       -2     
  Lines         456      423      -33     
==========================================
- Hits          307      287      -20     
+ Misses        141      125      -16     
- Partials        8       11       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.