Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplified workflow setup for HTTP middleware #280

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

johnabass
Copy link
Contributor

No description provided.

@johnabass johnabass merged commit b82c8f1 into main Aug 15, 2024
17 checks passed
@johnabass johnabass deleted the feature/simpler-middleware-options branch August 15, 2024 22:14
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.71%. Comparing base (58b9aab) to head (da69b50).
Report is 2 commits behind head on main.

Files Patch % Lines
basculehttp/middleware.go 12.50% 6 Missing and 1 partial ⚠️
basculehttp/authorizer.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   78.96%   77.71%   -1.25%     
==========================================
  Files          16       18       +2     
  Lines         542      552      +10     
==========================================
+ Hits          428      429       +1     
- Misses        104      112       +8     
- Partials       10       11       +1     
Flag Coverage Δ
unittests 77.71% <25.00%> (-1.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant