Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored challenge API #281

Merged
merged 1 commit into from
Aug 16, 2024
Merged

refactored challenge API #281

merged 1 commit into from
Aug 16, 2024

Conversation

johnabass
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 89.81481% with 11 lines in your changes missing coverage. Please review.

Project coverage is 83.65%. Comparing base (b82c8f1) to head (04d0232).
Report is 2 commits behind head on main.

Files Patch % Lines
basculehttp/middleware.go 50.00% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   77.71%   83.65%   +5.93%     
==========================================
  Files          18       19       +1     
  Lines         552      618      +66     
==========================================
+ Hits          429      517      +88     
+ Misses        112       89      -23     
- Partials       11       12       +1     
Flag Coverage Δ
unittests 83.65% <89.81%> (+5.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnabass johnabass merged commit dcb46b0 into main Aug 16, 2024
19 checks passed
@johnabass johnabass deleted the feature/clearer-challenge branch August 16, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant