Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title: Memory leak fix #44

Merged
merged 2 commits into from
May 24, 2023
Merged

Title: Memory leak fix #44

merged 2 commits into from
May 24, 2023

Conversation

akif1716
Copy link

Reason for change : The order of unreferencing was wrong, leading to leak redirectURL struct member as the parent reference is freed first and then tried to free the child of freed parent pointer. This commit fixes the same

akif1716 and others added 2 commits May 24, 2023 20:52
@akif1716
Title: Memory leak fix
7e0eab0 
Reason for change : The order of unreferencing was wrong, leading to leak redirectURL struct member
as the parent reference is freed first and then tried to free the child of freed parent pointer.
This commit fixes the same

Signed-off-by: Mohamed Shaikh <[email protected]>
@akif1716
Update nopoll_conn.c
7d2150c 
adjusted indentation
@schmidtw schmidtw merged commit 39ee89f into xmidt-org:nopoll_yocto May 24, 2023
@kraj
Copy link
Collaborator

kraj commented May 24, 2023

This looks a good fix to upstream as well. Squash both into one and send a PR to https://github.com/ASPLes/nopoll

@akif1716
Copy link
Author

This looks a good fix to upstream as well. Squash both into one and send a PR to https://github.com/ASPLes/nopoll

Hi @kraj , this fix cannot be upstreamed to https://github.com/ASPLes/nopoll as the source is different there and the pointer RedirectURL is missing in ASPLes master branch.
this is only added in comcast nopoll_yocto branch

@kraj
Copy link
Collaborator

kraj commented May 24, 2023

This looks a good fix to upstream as well. Squash both into one and send a PR to https://github.com/ASPLes/nopoll

Hi @kraj , this fix cannot be upstreamed to https://github.com/ASPLes/nopoll as the source is different there and the pointer RedirectURL is missing in ASPLes master branch. this is only added in comcast nopoll_yocto branch

thanks.

@shilpa24balaji
Copy link
Collaborator

@kraj @schmidtw We had submitted PR ASPLes#50 for the URL redirect changes but its not accepted yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilpa24balaji shilpa24balaji shilpa24balaji approved these changes

@schmidtw schmidtw Awaiting requested review from schmidtw

@sadhyama sadhyama Awaiting requested review from sadhyama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akif1716 @kraj @shilpa24balaji @schmidtw