Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize the deviceid before it is put into the logs for ease of sea… #442

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

schmidtw
Copy link
Member

…rching in the future.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #442 (1791577) into main (ce0453b) will increase coverage by 0.28%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   45.35%   45.63%   +0.28%     
==========================================
  Files          15       15              
  Lines        1162     1168       +6     
==========================================
+ Hits          527      533       +6     
  Misses        623      623              
  Partials       12       12              
Flag Coverage Δ
unittests 45.63% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
transaction/transactor.go 93.33% <100.00%> (+0.40%) ⬆️

Copy link
Contributor

@maurafortino maurafortino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@schmidtw schmidtw merged commit fe5b7d0 into main Aug 10, 2023
11 checks passed
@schmidtw schmidtw deleted the normalize-deviceid branch August 10, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants