Updates for new caduceus work #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vulnerable Libraries (3)
More info on how to fix Vulnerable Libraries in Go. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
maurafortino
commented
Sep 5, 2024
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "Failed to initialize v2 endpoint middleware: %v\n", err) | ||
| return err | ||
| if in.PreviousVersion { |
There was a problem hiding this comment.
are we getting rid of fixV2Middleware once new webhook and kafka updates are completed?
this right now is checking if it's v2 and if yes we use the fixv2middleware otherwise it's not used
maurafortino
commented
Sep 5, 2024
| @@ -63,6 +63,7 @@ cpuprofile | |||
| tr1d1um | |||
| .ignore | |||
| .vscode | |||
| .yaml | |||
There was a problem hiding this comment.
i added a new .yaml folder for myself for running tests with yaml file that has secrets in it so i don't accidentally push that file
There was a problem hiding this comment.
can you use .dev/* instead?
Suggested change
| .yaml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Included:
-updated: ancla & webhook-schema which includes adding in the new validation functions
-added check for previous version in the routes (will we be getting rid of the v2 fix middleware?)
this does not include a new endpoint for kafka - have a couple of questions regarding the new endpoints