-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for new caduceus work #561
Conversation
Vulnerable Libraries (3)
More info on how to fix Vulnerable Libraries in Go. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
if err != nil { | ||
fmt.Fprintf(os.Stderr, "Failed to initialize v2 endpoint middleware: %v\n", err) | ||
return err | ||
if in.PreviousVersion { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we getting rid of fixV2Middleware once new webhook and kafka updates are completed?
this right now is checking if it's v2 and if yes we use the fixv2middleware otherwise it's not used
@@ -63,6 +63,7 @@ cpuprofile | |||
tr1d1um | |||
.ignore | |||
.vscode | |||
.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added a new .yaml folder for myself for running tests with yaml file that has secrets in it so i don't accidentally push that file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use .dev/*
instead?
.yaml |
What's Included:
-updated: ancla & webhook-schema which includes adding in the new validation functions
-added check for previous version in the routes (will we be getting rid of the v2 fix middleware?)
this does not include a new endpoint for kafka - have a couple of questions regarding the new endpoints